Skip to content

Use FirstPipeInstance setting in named pipes transport #48609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 6, 2023
Merged

Use FirstPipeInstance setting in named pipes transport #48609

merged 4 commits into from
Jun 6, 2023

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Jun 5, 2023 •
edited
Loading

Addresses #14207

Use new FirstPipeInstance setting in named pipes transport.

Works well. FYI @jozkee @adamsitnik @jeffhandley

adamsitnik
adamsitnik reviewed Jun 5, 2023
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am glad to see that you were able to both simplify the code and increase reliability by using the new API. 👍

@JamesNK JamesNK merged commit e4c6621 into main Jun 6, 2023
@JamesNK JamesNK deleted the jamesnk/namedpipes-firstpipeinstance branch June 6, 2023 02:07
@ghost ghost added this to the 8.0-preview6 milestone Jun 6, 2023
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsitnik adamsitnik adamsitnik left review comments

@Tratcher Tratcher Tratcher approved these changes

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@mgravell mgravell Awaiting requested review from mgravell mgravell is a code owner

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
8.0-preview6
Development

Successfully merging this pull request may close these issues.
4 participants
@JamesNK @Tratcher @adamsitnik @amcasey