Skip to content

[Blazor] SupplyParameterFromForm dictionary support #48565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 7, 2023
Merged

[Blazor] SupplyParameterFromForm dictionary support #48565

merged 5 commits into from
Jun 7, 2023

Conversation

javiercn
Copy link
Member

@javiercn javiercn commented Jun 1, 2023 •
edited
Loading

#46688 (comment)

Performance data comparison with MVC. Without optimizations:

Method DictionarySize Mean Error StdDev Median Op/s Ratio RatioSD Gen 0 Gen 1 Gen 2 Allocated
ModelBinding_Dictionary_Mvc 0 37.24 μs 1.225 μs 3.515 μs 36.80 μs 26,849.8 1.00 0.00 - - - 3 KB
ModelBinding_Dictionary_Components 0 25.46 μs 2.157 μs 5.904 μs 23.65 μs 39,273.2 0.69 0.16 - - - 2 KB
ModelBinding_Dictionary_Mvc 1 76.61 μs 3.605 μs 10.110 μs 74.20 μs 13,052.6 1.00 0.00 - - - 6 KB
ModelBinding_Dictionary_Components 1 32.89 μs 1.215 μs 3.485 μs 31.90 μs 30,400.0 0.43 0.08 - - - 2 KB
ModelBinding_Dictionary_Mvc 10 94.69 μs 1.904 μs 5.116 μs 94.05 μs 10,560.3 1.00 0.00 - - - 10 KB
ModelBinding_Dictionary_Components 10 40.79 μs 1.653 μs 4.717 μs 39.50 μs 24,515.6 0.43 0.05 - - - 5 KB
ModelBinding_Dictionary_Mvc 100 362.88 μs 14.591 μs 38.948 μs 355.40 μs 2,755.8 1.00 0.00 - - - 63 KB
ModelBinding_Dictionary_Components 100 120.84 μs 4.973 μs 13.945 μs 119.90 μs 8,275.4 0.33 0.04 - - - 28 KB
ModelBinding_Dictionary_Mvc 1000 2,952.31 μs 85.899 μs 227.791 μs 2,919.80 μs 338.7 1.00 0.00 - - - 593 KB
ModelBinding_Dictionary_Components 1000 646.13 μs 31.573 μs 89.051 μs 624.30 μs 1,547.7 0.21 0.03 - - - 175 KB

@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Jun 1, 2023
@javiercn javiercn force-pushed the javiercn/supply-from-form-dictionaries branch 2 times, most recently from 73bc09d to b43c86d Compare June 1, 2023 13:46
@javiercn javiercn marked this pull request as ready for review June 1, 2023 16:22
@javiercn javiercn requested a review from a team as a code owner June 1, 2023 16:22
@javiercn javiercn requested a review from MackinnonBuck June 1, 2023 20:35
MackinnonBuck
MackinnonBuck approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@MackinnonBuck MackinnonBuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me 👍

Base automatically changed from javiercn/supply-from-form-collections to main June 7, 2023 09:34
@javiercn javiercn requested a review from a team as a code owner June 7, 2023 09:34
@javiercn javiercn force-pushed the javiercn/supply-from-form-dictionaries branch from 6f08454 to fc31f00 Compare June 7, 2023 10:14
@javiercn javiercn merged commit 110522a into main Jun 7, 2023
@javiercn javiercn deleted the javiercn/supply-from-form-dictionaries branch June 7, 2023 11:38
@ghost ghost added this to the 8.0-preview6 milestone Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MackinnonBuck MackinnonBuck MackinnonBuck approved these changes

Assignees
No one assigned
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Milestone
8.0-preview6
Development

Successfully merging this pull request may close these issues.
2 participants
@javiercn @MackinnonBuck