Skip to content

Ship Microsoft.AspNetCore.WebUtilities, Microsoft.Net.Http.Headers as packages #48265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 17, 2023

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented May 16, 2023

Fixes #48068. WebUtilities is used by blazor wasm projects that don't have access to the SharedFx (and it depends on Headers)

@wtgodbe wtgodbe requested a review from a team May 16, 2023 20:26
@ghost ghost added needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically area-runtime area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework labels May 16, 2023
@Tratcher
Copy link
Member

What about its dependencies like Microsoft.Net.Http.Headers?

@wtgodbe
Copy link
Member Author

wtgodbe commented May 16, 2023

What about its dependencies like Microsoft.Net.Http.Headers?

Good call. Looks like the chain ends there, so I'll just update that one

Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to un-deprecate these packages on nuget.org.

@wtgodbe
Copy link
Member Author

wtgodbe commented May 16, 2023

We'll need to un-deprecate these packages on nuget.org.

Deprecation applies to specific versions, so as soon as there's a new version the message should go away (unless you click on one of the deprecated versions)

@wtgodbe wtgodbe requested a review from mkArtakMSFT May 16, 2023 21:30
@wtgodbe wtgodbe changed the title Ship Microsoft.AspNetCore.WebUtilities as a package Ship Microsoft.AspNetCore.WebUtilities, Microsoft.Net.Http.Headers as packages May 16, 2023
@BrennanConroy
Copy link
Member

Do you also need to add

<ItemGroup>
  <SupportedPlatform Include="browser" />
</ItemGroup>

?

@wtgodbe
Copy link
Member Author

wtgodbe commented May 16, 2023

Do you also need to add

I wasn't aware of that, but from other projects in the repo it looks like I do - is there a doc about this somewhere I can look through?

@BrennanConroy
Copy link
Member

There is the generic doc about it
https://learn.microsoft.com/en-us/dotnet/standard/analyzers/platform-compat-analyzer
From my understanding, if you add that item you'll now get analyzer warnings for using APIs that won't work in the browser. And since we're making these packages for the purpose of using in the browser it's probably a good idea to add it.

@amcasey amcasey removed the needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically label May 16, 2023
@wtgodbe wtgodbe merged commit e9505bc into main May 17, 2023
@wtgodbe wtgodbe deleted the wtgodbe/Package branch May 17, 2023 16:03
@ghost ghost added this to the 8.0-preview5 milestone May 17, 2023
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to Base64UrlEncode in Blazor WebAssembly client now that Microsoft.AspNetCore.WebUtilities has been deprecated?
4 participants