Skip to content

Uses Fallback When Without Repository #48103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 10, 2023
Merged

Uses Fallback When Without Repository #48103

merged 4 commits into from
Jun 10, 2023

Conversation

feiyun0112
Copy link
Contributor

fix #48079

@ghost ghost added area-dataprotection Includes: DataProtection community-contribution Indicates that the PR has been added by a community member labels May 6, 2023
@ghost
Copy link

ghost commented May 6, 2023

Thanks for your PR, @feiyun0112. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@mitchdenny
Copy link
Member

@eerhardt PTAL

@mkArtakMSFT
Copy link
Contributor

@halter73 can you please review this when you get time? Thanks!

eerhardt
eerhardt approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @feiyun0112!

This seems reasonable to me.

@ghost
Copy link

ghost commented May 22, 2023

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no breaking changes are introduced, please leave an /azp run comment here to rerun the CI pipeline and confirm success before merging the change.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label May 22, 2023
@BrennanConroy
Copy link
Member

@feiyun0112 Looks like this might have a conflict from the recent trimming changes to DataProtection that @eerhardt did. I think it should be an easy fix, could you give it a try?

@halter73
Copy link
Member

halter73 commented Jun 9, 2023

/azp run

@ghost ghost removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jun 9, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@halter73 halter73 enabled auto-merge (squash) June 9, 2023 22:31
@halter73 halter73 merged commit adf7c0a into dotnet:main Jun 10, 2023
@ghost ghost added this to the 8.0-preview6 milestone Jun 10, 2023
@feiyun0112 feiyun0112 deleted the issue-48079 branch June 10, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eerhardt eerhardt eerhardt approved these changes

Assignees

@halter73 halter73

Labels
area-dataprotection Includes: DataProtection community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
8.0-preview6
Development

Successfully merging this pull request may close these issues.

DataProtectionProvider.Create(string applicationName, X509Certificate2 certificate) never works
6 participants
@feiyun0112 @mitchdenny @mkArtakMSFT @BrennanConroy @halter73 @eerhardt