Skip to content

Remove hardcoded System.Security.Cryptography.Xml version #48029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2023

Conversation

Tratcher
Copy link
Member

@Tratcher Tratcher commented May 2, 2023

Reverting this change to unblock dotnet/installer#16275. We'll see about a propper fix later.

@Tratcher Tratcher requested a review from mmitche May 2, 2023 17:51
@Tratcher Tratcher self-assigned this May 2, 2023
@Tratcher Tratcher requested review from a team and wtgodbe as code owners May 2, 2023 17:51
@ghost ghost added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework labels May 2, 2023
@ghost
Copy link

ghost commented May 2, 2023

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@wtgodbe
Copy link
Member

wtgodbe commented May 2, 2023

Hmm, looks like the change was needed? Maybe we can add crypto.xml to https://github.com/dotnet/aspnetcore/blob/main/eng/SourceBuildPrebuiltBaseline.xml (and remove

<RepoTasksSystemSecurityCryptographyXmlVersion>6.0.1</RepoTasksSystemSecurityCryptographyXmlVersion>
) - but I'm not confident that's correct

@Tratcher Tratcher disabled auto-merge May 2, 2023 18:13
Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you file an issue against Matt as well?

@Tratcher Tratcher merged commit 42d14c4 into main May 2, 2023
@Tratcher Tratcher deleted the tratcher/crypto_deps branch May 2, 2023 21:06
@ghost ghost added this to the 8.0-preview5 milestone May 2, 2023
@Tratcher
Copy link
Member Author

Tratcher commented May 2, 2023

#48033

RussKie added a commit that referenced this pull request Sep 15, 2023
@RussKie RussKie mentioned this pull request Sep 15, 2023
wtgodbe pushed a commit that referenced this pull request Sep 18, 2023
SteveSandersonMS pushed a commit that referenced this pull request Sep 20, 2023
* Revert "Remove hardcoded System.Security.Cryptography.Xml version (#48029)" (#50723)

This reverts commit 42d14c4.

* [Blazor] Prerendered state (#50742)

[Blazor] Adds support for persting prerendered state on Blazor Web applications.
* Persists state both for server and webassembly as necessary.
* Initializes the state when a given interactive runtime is initialized and renders the first set of components.
  * On WebAssembly, this is the first time the app starts.
  * On Server this happens every time a circuit starts.
* The state is available during the first render, until the components reach quiescence.

The approach we follow is different for server and webassembly:
* On Server, we support initializing the circuit with an empty set of descriptors and in that case, we delay initialization until the first `UpdateRootComponents` call is issued.
  * This is because it's hard to deal with the security constraints imposed by starting a new circuit multiple times, and its easier to handle them within UpdateRootComponents. We might switch this approach in the future to go through `StartCircuit` too.
* On WebAssembly, we query for the initial set of webassembly components when we are starting the runtime in a Blazor Web Scenario.
  * We do this because Blazor WebAssembly offers a programatic API to render root components at a given location defined by their selectors, so we need to make sure that those components can receive state at the same time the initial set of WebAssembly components added to the page.

There are a set of tests validating different behaviors with regards to enhanced navigation and streaming rendering, as well as making sure that auto mode can access the state on Server and WebAssembly, and that Server gets new state every time a circuit is opened.

* Make IEmailSender more customizable (#50301)

* Make IEmailSender more customizable

* Remove unnecessary metadata

* Add TUser parameter

* React to API review feedback

* Fix IdentitySample.DefaultUI

* Update branding to RTM (#50799)

---------

Co-authored-by: Igor Velikorossov <[email protected]>
Co-authored-by: Javier Calvarro Nelson <[email protected]>
Co-authored-by: Stephen Halter <[email protected]>
Co-authored-by: William Godbe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants