Replace AssignToProperties with SetParameterProperties, which also clears unspecified parameter properties (imported from Blazor PR 1108) #4797
Conversation
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>netstandard2.0</TargetFramework> | ||
| <Description>Components feature for ASP.NET Core.</Description> | ||
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> |
There was a problem hiding this comment.
This is because this PR adds a usage of stackalloc, and prior to netstandard2.1, that is always treated as unsafe.
Once we go to netstandard2.1 the unsafe modifier can be removed.
There was a problem hiding this comment.
hmm, I think that's due to the language version not the TFM right? Either way I'm not too nervous about this as long as it works in wasm.
|
@rynowak Another one. In this specific case it's worth being aware of the low-level thing I've added with an |
|
|
||
| // TODO: Once we're able to move to netstandard2.1, this can be changed to be | ||
| // a Span<bool> and then the enclosing method no longer needs to be 'unsafe' | ||
| bool* usageFlags = stackalloc bool[numWriters]; |
| parameterWriters = CreateParameterWriters(targetType); | ||
| _cachedParameterWriters[targetType] = parameterWriters; | ||
| writers = new WritersForType(targetType); | ||
| _cachedWritersByType[targetType] = writers; |
There was a problem hiding this comment.
nit: changing this to TryAdd is a little more friendly and makes the pattern obvious.
|
What should I do about failing e2e test ? It's because it calls a page without the date parameter so the date property get date default value. I can handle it by overriding OnParameterSet I think. |
SteveSandersonMS
force-pushed
the
stevesa/import-blazor-pr-1108
branch
from
8cf1594 to
4175517
Compare
@RemiBou Good point - I've added a fix for that. |
|
Thanks @SteveSandersonMS . I think you changed pretty much all my code, but it's for the best and it'll help me greatly in the future ! |
Imported from dotnet/blazor#1108