Skip to content

Fixes CI build failures after conflicting merge affecting RDG baselines. #47917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2023
Merged

Fixes CI build failures after conflicting merge affecting RDG baselines. #47917

merged 1 commit into from
Apr 27, 2023

Conversation

mitchdenny
Copy link
Member

Fixes CI build failures after conflicting merge affecting RDG baselines.

@ghost ghost added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework area-runtime labels Apr 27, 2023
@ghost
Copy link

ghost commented Apr 27, 2023

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@mitchdenny
Copy link
Member Author

/cc @eerhardt @captainsafia

eerhardt
eerhardt approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If CI is green - LGTM

@mitchdenny mitchdenny enabled auto-merge (squash) April 27, 2023 00:16
@mitchdenny mitchdenny merged commit 58940e3 into dotnet:main Apr 27, 2023
@ghost ghost added this to the 8.0-preview5 milestone Apr 27, 2023
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eerhardt eerhardt eerhardt approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@captainsafia captainsafia Awaiting requested review from captainsafia captainsafia is a code owner

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
8.0-preview5
Development

Successfully merging this pull request may close these issues.
3 participants
@mitchdenny @eerhardt @amcasey