[GenerateEmbeddedResourcesManifest] handle Items with empty LogicalName #29306 #47887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
needs-area-label
|
Thanks for your PR, @rafd123. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
@dotnet-policy-service agree |
mkArtakMSFT
added
area-mvc
There was a problem hiding this comment.
Thanks for the contribution, @rafd123!
Just a small suggestion and then this should be good to go.
src/FileProviders/Manifest.MSBuildTask/src/GenerateEmbeddedResourcesManifest.cs
Outdated
Show resolved
Hide resolved
dotnet#29306 A LogicalName isn't assigned to Resx resources. See https://github.com/dotnet/msbuild/blob/6300d22b25cc1bcb634663bd7087e31d8312bb15/src/Tasks/CreateManifestResourceName.cs#L231-L238 As a result, GenerateEmbeddedResourcesManifest needs to handle this possibility...otherwise it'll generate an invalid Microsoft.Extensions.FileProviders.Embedded.Manifest.xml with empty name attribute for File elements and empty ResourcePath elements.
rafd123
force-pushed
the
issue-29306-handle-missing-logicalname
branch
from
8ca5dee to
12383a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[GenerateEmbeddedResourcesManifest] handle Items with empty LogicalName #29306
Ensure that the
GenerateEmbeddedResourcesManifesttask handles the possibility ofItems with noLogicalNameDescription
A
LogicalNameisn't assigned to Resx resources. See https://github.com/dotnet/msbuild/blob/6300d22b25cc1bcb634663bd7087e31d8312bb15/src/Tasks/CreateManifestResourceName.cs#L231-L238As a result,
GenerateEmbeddedResourcesManifestneeds to handle this possibility...otherwise it'll generate an invalidMicrosoft.Extensions.FileProviders.Embedded.Manifest.xmlwith empty name attributes forFileelements and emptyResourcePathelements.Fixes #29306