Skip to content

[main] Update dependencies from dotnet/runtime dotnet/efcore #47650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 13, 2023

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Apr 11, 2023

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: 32db3699-5666-45da-a1b7-08d8b804cd75
  • Build: 20230412.4
  • Date Produced: April 12, 2023 3:50:28 PM UTC
  • Commit: 5117e1f78d2f4924181a9ed6d1fd525f27a9fc91
  • Branch: refs/heads/main

From https://github.com/dotnet/efcore

  • Subscription: 8ce5251e-8269-419d-3b2a-08d8b8050dda
  • Build: 20230412.3
  • Date Produced: April 12, 2023 8:46:34 PM UTC
  • Commit: 596dcd6d7b7a67082fca25e6a832d252547ffa51
  • Branch: refs/heads/main

…0411.2

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Http , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.Platforms , System.Configuration.ConfigurationManager , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.DirectoryServices.Protocols , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Reflection.Metadata , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Threading.Channels , System.Threading.RateLimiting
 From Version 8.0.0-preview.4.23210.3 -> To Version 8.0.0-preview.4.23211.2
@dotnet-maestro dotnet-maestro bot requested review from a team and wtgodbe as code owners April 11, 2023 16:35
@ghost ghost added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼 labels Apr 11, 2023
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

@GrabYourPitchforks
Copy link
Member

For resolution, see the heading If you're creating a custom System.Exception-derived type at https://aka.ms/dotnet-warnings/syslib0051.

My recommendations:

  • For Exception-derived types which are internal, remove the [Serializable] attribute, the serialization ctor, and the GetObjectData method override.
  • For Exception-derived types which are publicly exposed and for which you need to maintain API compat, leave the serialization ctors and GetObjectData overrides as-is but mark them [Obsolete]. This is the same technique we use in the runtime. The link above gives examples of this technique.

…0412.4

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Http , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.Platforms , System.Configuration.ConfigurationManager , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.DirectoryServices.Protocols , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Reflection.Metadata , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Threading.Channels , System.Threading.RateLimiting
 From Version 8.0.0-preview.4.23210.3 -> To Version 8.0.0-preview.4.23212.4
@lewing
Copy link
Member

lewing commented Apr 12, 2023

This is blocking sdk flow to installer source build now. We won't be able to take a new sdk into installer until this is resolved and flows into dotnet/sdk

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to suppress the warning another way. I will fix it up.

@lewing
Copy link
Member

lewing commented Apr 12, 2023

@javiercn javiercn self-requested a review as a code owner April 12, 2023 20:33
…412.3

dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Design , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.Tools
 From Version 8.0.0-preview.4.23210.7 -> To Version 8.0.0-preview.4.23212.3
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/runtime [main] Update dependencies from dotnet/runtime dotnet/efcore Apr 12, 2023
@eerhardt
Copy link
Member

Looks like this needs #47639 as well. But that doesn't build because there is no Obsoletions in aspnetcore.

@GrabYourPitchforks @Tratcher

@eerhardt eerhardt dismissed their stale review April 12, 2023 21:19

I've fixed the code that I didn't want merged.

@javiercn javiercn requested a review from a team as a code owner April 12, 2023 21:44
@javiercn
Copy link
Member

What do we do with:

artifacts/source-build/self/src/src/submodules/MessagePack-CSharp/src/MessagePack.UnityClient/Assets/Scripts/MessagePack/MessagePackSerializationException.cs#L53

@wtgodbe thoughts? (Since this is a submodule we would need to update)

@wtgodbe
Copy link
Member

wtgodbe commented Apr 12, 2023

What do we do with:

artifacts/source-build/self/src/src/submodules/MessagePack-CSharp/src/MessagePack.UnityClient/Assets/Scripts/MessagePack/MessagePackSerializationException.cs#L53

@wtgodbe thoughts? (Since this is a submodule we would need to update)

We own that submodule, https://github.com/aspnet/MessagePack-CSharp/tree/master. We should update it, then ingest the update in this PR.

@danmoseley
Copy link
Member

created aspnet/MessagePack-CSharp#3

@lewing
Copy link
Member

lewing commented Apr 13, 2023

'src\Shared\runtime\Http2\Hpack\HPackDecodingException.cs(25,74): error CS0122: (NETCORE_ENGINEERING_TELEMETRY=Build) 'Obsoletions' is inaccessible due to its protection level'

@JamesNK
Copy link
Member

JamesNK commented Apr 13, 2023

Need to add <Compile Include="$(SharedSourceRoot)runtime\Obsoletions.cs" LinkBase="Shared\Obsoletions.cs" /> to Kestrel csproj.

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞 hopefully this fixes it.

@JamesNK
Copy link
Member

JamesNK commented Apr 13, 2023

Updated tests to react to dotnet/runtime#84048. StopAsync no longer wraps the error with AggregateException when there is one exception.

@dotnet-maestro dotnet-maestro bot merged commit 0dd576f into main Apr 13, 2023
@dotnet-maestro dotnet-maestro bot deleted the darc-main-5cd36cf1-598f-4c1e-8673-88dc5dfa056b branch April 13, 2023 05:25
@ghost ghost added this to the 8.0-preview4 milestone Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants