Skip to content

Update Selenium versions #46790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Update Selenium versions #46790

merged 1 commit into from
Feb 24, 2023

Conversation

halter73
Copy link
Member

We're hoping this fixes the aspnetcore-components-e2e test pipeline that has been timing out.

@halter73 halter73 requested review from a team, dougbu and wtgodbe as code owners February 22, 2023 01:52
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Feb 22, 2023
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine but I don't think any of the updated packages are used in the aspnetcore-components-e2e pipeline. If it fixes that pipeline, great. If not, probably need to focus on the selenium-config.json versions. Either way, merging this makes sense.

@mgravell
Copy link
Member

feed lib updates have been requested for these 3 (I've done a downstream dependency tree check; looks like just these 3)

@mgravell
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@SteveSandersonMS
Copy link
Member

It doesn't appear to be helping, unfortunately.

On closer inspection the problem looks stranger and worse than simply "our packages are the wrong versions". Some of the E2E tests are in fact running and passing, and others don't:

  • You can see some of them work in the logs because there are occasional blocks where lots of HTTP requests are going through (e.g, Request finished HTTP/1.1 GET http://127.0.0.1:43397/subdir/_framework/dotnet.wasm). That would only be happening if the Selenium server did start up properly and did launch a browser, and it did start loading and running the test app web pages.
  • ... but most of them fail after saying Couldn't create a Selenium remote driver client. The server is irresponsive.

There may be something more subtle that's different between the old and new Selenium/chromedriver versions that means the new version has become unable to start reliably.

@SteveSandersonMS
Copy link
Member

SteveSandersonMS commented Feb 22, 2023

I also notice by comparing the old-good build logs and the new-bad ones, that the new-bad ones have started saying this right around where the Selenium client connection is being started:

[WARNING]: virtual void DevToolsClientImpl::AddListener(DevToolsEventListener *) subscribing a listener to the already connected DevToolsClient. Connection notification will not arrive

The old-good builds did not say that.

@SteveSandersonMS
Copy link
Member

May be related: https://bugs.chromium.org/p/chromedriver/issues/detail?id=4330

@mgravell
Copy link
Member

Initial build doesn't seem to have made a difference; killed after 2 hours :( retrying, but: I have very low confidence

@mgravell
Copy link
Member

@SteveSandersonMS that looks likely; also looks like we're not alone... https://stackoverflow.com/questions/75510453/i-am-generating-listener-error-in-console

@SteveSandersonMS
Copy link
Member

This is from that chromedriver bug:

image

I don't know, but maybe this means the issue goes away in v111 and we might be stuck with it until then (we're on 110 now). It would help if I understood more about what they are saying was broken and is now fixed. And our issue could still be completely unrelated to that.

@SteveSandersonMS
Copy link
Member

Good news - I've been able to repro this locally.

@dougbu
Copy link
Contributor

dougbu commented Feb 22, 2023

  1. Is there a workaround in any of the issues and questions -- aside from waiting for v111❔
  2. Has the pipeline been rerun since @mgravell got FR to add the bumped NuGet package versions into dotnet-public❔ As I mentioned earlier, the changes in this PR are useful even if they don't fix the aspnetcore-components-e2e pipeline.

@mgravell
Copy link
Member

mgravell commented Feb 22, 2023

@dougbu

  1. we're still finding out; there isn't much info on the external issue report
  2. yes, no change

As for updating the selenium bits: that sounds advantageous simply in principle, but we need to stabilize the CI either "first" or "at the same time"; I'd be hesitant to merge this before that if it doesn't fix the issue, as it adds more moving parts to juggle

@SteveSandersonMS
Copy link
Member

It turns out the DevToolsClientImpl::AddListener(DevToolsEventListener *) thing is not the cause of the timeout issue. It appears to be a completely unrelated and harmless warning that was recently introduced.

I think I have tracked down the real timeout cause and have a fix at #46812

@MackinnonBuck
Copy link
Member

It seems like #46812 did indeed fix the problem. I'm still going to continue monitoring this PR, given we want to keep our Selenium dependencies relatively up-to-date anyway.

@MackinnonBuck
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@MackinnonBuck MackinnonBuck merged commit a11fec5 into main Feb 24, 2023
@MackinnonBuck MackinnonBuck deleted the halter73/update-selenium branch February 24, 2023 19:08
@ghost ghost added this to the 8.0-preview2 milestone Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants