Update to Alpine 3.16

[wtgodbe]

Part of #46555

[wtgodbe]

Helix-matrix run: https://dev.azure.com/dnceng-public/public/_build/results?buildId=166496&view=results

[wtgodbe]

Lots of test failures here, all seemingly related to the French culture - tagging individual owners

[wtgodbe]

Lots of ModelBinding failures, e.g. Microsoft.AspNetCore.Mvc.ModelBinding.Binders.DecimalModelBinderTest.BindModel_ReturnsModel_IfAttemptedValueIsValid_FrenchTwelvePointFive(destinationType: typeof(decimal))

Assert.Equal() Failure
Expected: 12.5
Actual: 125

@brunolins16 could you take a look?

[wtgodbe]

Microsoft.AspNetCore.Html.Test.HtmlContentBuilderExtensionsTest.Builder_AppendFormat_WithDifferentCulture

Assert.Equal() Failure
↓ (pos 13)
Expected: HtmlEncode[[1,21]] in french!
Actual: HtmlEncode[[1.21]] in french!
↑ (pos 13)

Not sure who owns this one - @JamesNK? link

[wtgodbe]

2023-02-10T00:06:42.6138111Z Failed Microsoft.AspNetCore.Mvc.Formatters.NewtonsoftJsonInputFormatterTest.ReadAsync_WithReadJsonWithRequestCulture_DeserializesUsingRequestCulture(dateString: "15/05/2019", culture: "fr-FR") [66 ms]
2023-02-10T00:06:42.6138991Z Error Message:
2023-02-10T00:06:42.6139493Z Assert.False() Failure
2023-02-10T00:06:42.6139992Z Expected: False
2023-02-10T00:06:42.6140512Z Actual: True
2023-02-10T00:06:42.6141094Z Stack Trace:
2023-02-10T00:06:42.6141681Z at Microsoft.AspNetCore.Mvc.Formatters.NewtonsoftJsonInputFormatterTest.ReadAsync_WithReadJsonWithRequestCulture_DeserializesUsingRequestCulture(String dateString, String culture) in /_/src/Mvc/Mvc.NewtonsoftJson/test/NewtonsoftJsonInputFormatterTest.cs:line 514

@JamesNK I guess this is you as well - logs

[wtgodbe]

The failures may be related to an issue with the docker image - dotnet/dotnet-buildtools-prereqs-docker#798

[brunolins16]

The failures may be related to an issue with the docker image - dotnet/dotnet-buildtools-prereqs-docker#798

IDK much about but I took a look at the ModelBinding issues and all of them are related to scenarios where we are testing formatting with different cultures (French, Spanish, Russian, Traditional Chinese) and definitely could be related to this.

[wtgodbe]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[wtgodbe]

I believe https://dev.azure.com/dnceng-public/public/_build/results?buildId=169872&view=results will use the updated 3.16 image

[brunolins16]

I believe https://dev.azure.com/dnceng-public/public/_build/results?buildId=169872&view=results will use the updated 3.16 image

If it is using 3.16, I believe the change did not fix the issue :(.

[brunolins16]

@wtgodbe we were using 3.14 before, right?

Do you know which customizations we have in mcr.microsoft.com/dotnet-buildtools/prereqs:alpine-3.14-local? I am asking because the 3.16 base image is a plain alpine:3.16

[wtgodbe]

I might have read the docker repo wrong, going to try the staging image (I think it hasn't been rolled out yet). If that works I'll wait until the rollout & update this PR to use the official image again

[wtgodbe]

https://dev.azure.com/dnceng-public/public/_build/results?buildId=170242&view=results

[wtgodbe]

Ok, that worked. @mthalman what day does the weekly docker image rollout happen?

[mthalman]

Wednesday or Thursday
cc @riarenas

[wtgodbe]

https://dev.azure.com/dnceng-public/public/_build/results?buildId=174852&view=results

[wtgodbe]

@dougbu can you review