Skip to content

Updated Microsoft.AspNetCore.Identity.UserOptions.RequireUniqueEmail flag description. #46552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

KamilRaszkiewicz
Copy link
Contributor

Updated Microsoft.AspNetCore.Identity.UserOptions.RequireUniqueEmail flag XML docs description.

Clarified what happens if we set this flag true.

Note

Wanted to simply write valid email, but it wouldn't be true as long as System.ComponentModel.DataAnnotations.EmailAddressAttribute.IsValid() is used to "validate" email value in Microsoft.AspNetCore.Identity.UserValidator

Fixes #46435

@ghost ghost added area-identity Includes: Identity and providers community-contribution Indicates that the PR has been added by a community member labels Feb 9, 2023
@ghost
Copy link

ghost commented Feb 9, 2023

Thanks for your PR, @KamilRaszkiewicz. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@mkArtakMSFT
Copy link
Contributor

Thanks for your PR, @KamilRaszkiewicz.
@HaoK can you please review this? Thanks!

Copy link
Member

@HaoK HaoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@HaoK HaoK merged commit 2cd5873 into dotnet:main Feb 10, 2023
@ghost ghost added this to the 8.0-preview2 milestone Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-identity Includes: Identity and providers community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Describe Microsoft.AspNetCore.Identity.UserOptions.RequireUniqueMail behaviour in documentation comments
3 participants