Skip to content

fix typo in log message #46540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2023
Merged

fix typo in log message #46540

merged 2 commits into from
Feb 11, 2023

Conversation

OwnageIsMagic
Copy link
Contributor

Fix typo


I was looking for a way to disable this middleware for particular endpoint (pass-through scenario), but seems there is no way for partial opt out.
Are you willing to accept PR for something like this?

class DisableRequestDecompressionAttribute : Attribute, IRequestDecompressionMetadata
{
    bool Enabled { get; set; }
}

@ghost ghost added area-runtime community-contribution Indicates that the PR has been added by a community member labels Feb 9, 2023
@ghost
Copy link

ghost commented Feb 9, 2023

Thanks for your PR, @OwnageIsMagic. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@Tratcher
Copy link
Member

I was looking for a way to disable this middleware for particular endpoint (pass-through scenario), but seems there is no way for partial opt out.
Are you willing to accept PR for something like this?

Please open a separate issue using the API review template.

@danmoseley
Copy link
Member

also needs a fix here to make test pass.

"The maximum request body size as been disabled.");

@dnfadmin
Copy link

dnfadmin commented Feb 10, 2023

CLA assistant check
All CLA requirements met.

@danmoseley danmoseley merged commit ac542f4 into dotnet:main Feb 11, 2023
@ghost ghost added this to the 8.0-preview2 milestone Feb 11, 2023
@danmoseley
Copy link
Member

Thanks @OwnageIsMagic

@ghost
Copy link

ghost commented Feb 11, 2023

Hi @danmoseley. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@OwnageIsMagic
Copy link
Contributor Author

@danmoseley for not keeping it till hacktobefest? haha

@ghost
Copy link

ghost commented Feb 11, 2023

Hi @OwnageIsMagic. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@amcasey amcasey added area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants