Skip to content

Support manual loc builds creating a PR #46278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2023
Merged

Support manual loc builds creating a PR #46278

merged 1 commit into from
Jan 27, 2023

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Jan 26, 2023

  • we sometimes want / need to get a new loc PR faster than the schedule

@dougbu
Support manual loc builds creating a PR
00bac59 
- we sometimes want / need to get a new loc PR faster than the schedule
@dougbu dougbu added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 26, 2023
@dougbu dougbu requested review from a team and wtgodbe as code owners January 26, 2023 22:13
@ghost
Copy link

ghost commented Jan 26, 2023

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@dougbu
Copy link
Contributor Author

dougbu commented Jan 26, 2023 •
edited
Loading

Earlier today, I kicked off our aspnetcore-localization pipeline and watched as it did a bunch of work then not create a PR, leaving us w/ nothing to show for that work. I kicked off #20230126.3 using this branch but don't want to have to think about it next time.

@dougbu dougbu enabled auto-merge (squash) January 26, 2023 22:51
@dougbu
Copy link
Contributor Author

dougbu commented Jan 26, 2023

My internal manual build of this branch included the following important logging:

OneLocBuildClient.exe Information: 0 : Pull request created with ID '46279'.

Even better #46279 looks great❕

@dougbu dougbu merged commit b922de7 into dotnet:main Jan 27, 2023
@dougbu dougbu deleted the dougbu/create.loc.pr branch January 27, 2023 00:00
@ghost ghost added this to the 8.0-preview1 milestone Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
8.0-preview1
Development

Successfully merging this pull request may close these issues.
2 participants
@dougbu @wtgodbe