Skip to content

Don't depend on source-build job while it isn't running #46220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2023
Merged

Don't depend on source-build job while it isn't running #46220

merged 1 commit into from
Jan 23, 2023

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Jan 23, 2023

Missed this in the last PR for #46191 - internal builds are failing because the job doesn't exist. Need to revert this as part of that issue

@wtgodbe wtgodbe requested review from a team and dougbu as code owners January 23, 2023 17:45
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 23, 2023
@wtgodbe wtgodbe mentioned this pull request Jan 23, 2023
Closed
eerhardt
eerhardt approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Do we want to skip validation to get this in to kick off an official build?

@wtgodbe wtgodbe merged commit 7369057 into main Jan 23, 2023
@wtgodbe wtgodbe deleted the wtgodbe/sbdepend branch January 23, 2023 17:50
@ghost ghost added this to the 8.0-preview1 milestone Jan 23, 2023
@build-analysis build-analysis bot mentioned this pull request Jan 23, 2023
Open
2 tasks
atossell91 pushed a commit to atossell91/aspnetcore that referenced this pull request Jan 23, 2023
@wtgodbe @atossell91
Don't depend on source-build job while it isn't running (dotnet#46220)
83d1d87
wtgodbe added a commit that referenced this pull request Jan 24, 2023
@wtgodbe
Revert "Don't depend on source-build job while it isn't running (#46220…
7d923eb 
…)"

This reverts commit 7369057.
wtgodbe added a commit that referenced this pull request Jan 24, 2023
@dotnet-maestro @wtgodbe
[main] Update dependencies from dotnet/arcade (#46248)
c31b892 
* Update dependencies from https://github.com/dotnet/arcade build 20230123.10

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor
 From Version 8.0.0-beta.23067.5 -> To Version 8.0.0-beta.23073.10

* Revert "Don't depend on source-build job while it isn't running (#46220)"

This reverts commit 7369057.

* Revert "Skip Source Build for now (#46190)"

This reverts commit c77deeb.

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: wtgodbe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eerhardt eerhardt eerhardt approved these changes

@dougbu dougbu Awaiting requested review from dougbu

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
8.0-preview1
Development

Successfully merging this pull request may close these issues.
2 participants
@wtgodbe @eerhardt