Skip to content

[Mvc] Use ArgumentNullException.ThrowIfNull in ChecksumValidator #46174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

javiercn
Copy link
Member

{PR title}

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

{Detail}

Fixes #{bug number} (in this specific format)

@javiercn javiercn requested a review from a team as a code owner January 19, 2023 18:49
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jan 19, 2023
@javiercn javiercn enabled auto-merge (squash) January 19, 2023 18:50
@adityamandaleeka
Copy link
Member

adityamandaleeka commented Jan 19, 2023

@dotnet/aspnet-build Any idea what this submodule clone error is about? It's been observed on multiple PRs.

@wtgodbe
Copy link
Member

wtgodbe commented Jan 19, 2023

Interesting, haven't seen that one before - is it consistent?

@dotnet/source-build-internal have you seen this before when cloning submodules?

@wtgodbe
Copy link
Member

wtgodbe commented Jan 19, 2023

Some more context on the failure:

Cloning repository at: /__w/1/s/ -> /__w/1/s/artifacts/source-build/self/src/ ...
Creating empty clone at: /__w/1/s/artifacts/source-build/self/src/
Cloning into '/__w/1/s/artifacts/source-build/self/src'...
done.
Checking out sources...
Clone complete: /__w/1/s/ -> /__w/1/s/artifacts/source-build/self/src/
Entering 'src/submodules/MessagePack-CSharp'
Cloning repository at: . -> /__w/1/s/artifacts/source-build/self/src/src/submodules/MessagePack-CSharp ...
Destination already exists!
Clean is enabled: removing /__w/1/s/artifacts/source-build/self/src/src/submodules/MessagePack-CSharp and continuing...
Creating empty clone at: /__w/1/s/artifacts/source-build/self/src/src/submodules/MessagePack-CSharp
Cloning into '/__w/1/s/artifacts/source-build/self/src/src/submodules/MessagePack-CSharp'...
fatal: transport 'file' not allowed
fatal: run_command returned non-zero status for src/submodules/MessagePack-CSharp
.
/__w/1/s/.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23063.7/tools/SourceBuild/SourceBuildArcadeBuild.targets(170,5): error MSB3073: The command "git submodule foreach --recursive '/__w/1/s/.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23063.7/tools/SourceBuild/git-clone-to-dir.sh --source . --dest "/__w/1/s/artifacts/source-build/self/src/$sm_path" --clean'" exited with code 128. [/__w/1/s/.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23063.7/tools/Build.proj]
##[error].packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23063.7/tools/SourceBuild/SourceBuildArcadeBuild.targets(170,5): error MSB3073: The command "git submodule foreach --recursive '/__w/1/s/.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23063.7/tools/SourceBuild/git-clone-to-dir.sh --source . --dest "/__w/1/s/artifacts/source-build/self/src/$sm_path" --clean'" exited with code 128.

CC @crummel, @MichaelSimons - apparently this has been happening transiently on some of our PRs today and goes away on retry. The submodule in question hasn't been touched in 5 months - maybe fallout from an Arcade update?

@crummel
Copy link

crummel commented Jan 19, 2023

It's actually from a git update that disabled the file:// protocol by default for security reasons, so it probably depends on whether you're getting an up-to-date machine. We thought we wouldn't need to fix it because the 3.1 builds were going away but I reopened dotnet/source-build#3111 for it.

@mkArtakMSFT mkArtakMSFT disabled auto-merge January 19, 2023 21:18
@mkArtakMSFT mkArtakMSFT merged commit de8b5af into main Jan 19, 2023
@mkArtakMSFT mkArtakMSFT deleted the javiercn/fix-build-break branch January 19, 2023 21:18
@ghost ghost added this to the 8.0-preview1 milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants