Skip to content

Don't throw exception for unresolved type #46070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 13, 2023
Merged

Don't throw exception for unresolved type #46070

merged 2 commits into from
Jan 13, 2023

Conversation

captainsafia
Copy link
Member

No description provided.

@ghost ghost added the area-runtime label Jan 12, 2023
@build-analysis build-analysis bot mentioned this pull request Jan 12, 2023
Open
5 tasks
@JamesNK
Copy link
Member

JamesNK commented Jan 13, 2023

What's the reason for the change?

@captainsafia
Copy link
Member Author

What's the reason for the change?

This passed in CI because the tests there run under a Release build. It was failing tests locally because those run under a Debug build.

The reference added to the testing library fixes a legitimate error where the EmptyHttpResult type wasn't accessible in a code path that called into the filter pipeline.

@captainsafia captainsafia merged commit a527ac5 into main Jan 13, 2023
@captainsafia captainsafia deleted the safia/remove-throw branch January 13, 2023 01:24
@ghost ghost added this to the 8.0-preview1 milestone Jan 13, 2023
@captainsafia
Copy link
Member Author

/backport to release/7.0

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/aspnetcore/actions/runs/3907800097

@github-actions github-actions bot mentioned this pull request Jan 13, 2023
Merged
10 tasks
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunolins16 brunolins16 brunolins16 approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@javiercn javiercn Awaiting requested review from javiercn

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
8.0-preview1
Development

Successfully merging this pull request may close these issues.
4 participants
@captainsafia @JamesNK @brunolins16 @amcasey