-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Transport.Sockets.IOQueue -> IThreadPoolWorkItem #4601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LGTM |
@sebastienros Can you benchmark this? |
In combination with dotnet/coreclr#21159 this is the final piece to bring the steady state allocations for Plaintext Platform to 0 bytes/s (for 7M+ request/s) in .NET Core 3.0 Which fits with the goals of aspnet applications being able to run under lower memory conditions (See: "Proposal for .NET Core GC Support for Docker Limits") |
We need to collect a profile on Linux. To make sure we slash the allocations across the board. |
Benchmarking PlatformPlaintext on Windows with 512 connections
|
Memory 327 MB -> 282 MB suggests a positive impact 😄 |
@benaadams do you mind rebasing this? |
c5fe079
to
1a6d8f8
Compare
Rebased |
Resolves #4357
In combination with dotnet/coreclr#21159 this is the final piece to bring the steady state allocations for Plaintext Platform to 0 bytes/s (for 7M+ request/s) in .NET Core 3.0
Which fits with the goals of aspnet applications being able to run under lower memory conditions (See: "Proposal for .NET Core GC Support for Docker Limits")
/cc @sebastienros @halter73 @pakrym @davidfowl @Tratcher