Skip to content

Adopt consistent approach for defining InternalsVisibleTo in the repo #45748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 28, 2022
Merged

Adopt consistent approach for defining InternalsVisibleTo in the repo #45748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
279382d
Adopt consistent approach for defining InternalsVisibleTo in the repo
silamon Dec 24, 2022
c6d0ab1
Fix openapi project file
silamon Dec 24, 2022
b99885f
Remove using statements
silamon Dec 27, 2022
e2f722d
Remove duplicated http2cat
silamon Dec 27, 2022
10f829f
Fix InternalVisibleTo to InternalsVisibleTo
silamon Dec 27, 2022
e0184f6
Update AssemblyInfo.cs
Tratcher Dec 27, 2022
ad29eb9
Update AssemblyInfo.cs
Tratcher Dec 27, 2022
b086420
Update AssemblyInfo.cs
silamon Dec 28, 2022
e585950
Change the Public Key for DynamicProxyGenAssembly2
silamon Dec 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,4 +254,9 @@
<Import Project="eng\targets\Java.Common.props" Condition="'$(MSBuildProjectExtension)' == '.javaproj'" />
<Import Project="eng\targets\Helix.props" Condition=" $(IsTestProject) " />
<Import Project="eng\targets\FunctionalTestWithAssets.props" Condition=" $(IsTestProject) " />

<!-- Keys used by InternalsVisibleTo attributes. -->
<PropertyGroup>
<MoqPublicKey>0024000004800000940000000602000000240000525341310004000001000100c547cac37abd99c8db225ef2f6c8a3602f3b3606cc9891605d02baa56104f4cfc0734aa39b93bf7852f7d9266654753cc297e7d2edfe0bac1cdcf9f717241550e0a7b191195b7667bb4f64bcb8e2121380fd1d9d46ad2d92d2d15605093924cceaf74c4861eff62abf69b9291ed0a340e113be11e6a7d3113e92484cf7045cc7</MoqPublicKey>
</PropertyGroup>
</Project>
3 changes: 3 additions & 0 deletions src/Analyzers/Analyzers/src/Microsoft.AspNetCore.Analyzers.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,7 @@
<NuspecProperty Include="OutputSymbol=$(OutputPath)$(AssemblyName).pdb" />
</ItemGroup>

<ItemGroup>
<InternalsVisibleTo Include="Microsoft.AspNetCore.Analyzers.Test" />
</ItemGroup>
</Project>
6 changes: 0 additions & 6 deletions src/Analyzers/Analyzers/src/Properties/AssemblyInfo.cs
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions src/Antiforgery/src/Microsoft.AspNetCore.Antiforgery.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,8 @@
<Reference Include="Microsoft.Extensions.ObjectPool" />
</ItemGroup>

<ItemGroup>
<InternalsVisibleTo Include="DynamicProxyGenAssembly2" Key="$(MoqPublicKey)" />
<InternalsVisibleTo Include="Microsoft.AspNetCore.Antiforgery.Test" />
</ItemGroup>
</Project>
7 changes: 0 additions & 7 deletions src/Antiforgery/src/Properties/AssemblyInfo.cs
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions src/Azure/AzureAppServices.HostingStartup/src/AssemblyInfo.cs
View file
Open in desktop

This file was deleted.

3 changes: 3 additions & 0 deletions ...ppServices.HostingStartup/src/Microsoft.AspNetCore.AzureAppServices.HostingStartup.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,7 @@
<Reference Include="Microsoft.Extensions.Configuration.EnvironmentVariables" />
</ItemGroup>

<ItemGroup>
<InternalsVisibleTo Include="Microsoft.AspNetCore.AzureAppServicesIntegration.Tests" />
</ItemGroup>
</Project>
3 changes: 3 additions & 0 deletions ...e/AzureAppServicesIntegration/src/Microsoft.AspNetCore.AzureAppServicesIntegration.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,7 @@
<Reference Include="Microsoft.Extensions.Logging.AzureAppServices" />
</ItemGroup>

<ItemGroup>
<InternalsVisibleTo Include="Microsoft.AspNetCore.Hosting.Azure.AppServices.Tests" />
</ItemGroup>
</Project>
6 changes: 0 additions & 6 deletions src/Azure/AzureAppServicesIntegration/src/Properties/AssemblyInfo.cs
View file
Open in desktop

This file was deleted.

3 changes: 3 additions & 0 deletions src/Components/Analyzers/src/Microsoft.AspNetCore.Components.Analyzers.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,7 @@
<None Include="buildTransitive/netstandard2.0/*" Pack="true" PackagePath="buildTransitive/netstandard2.0" />
</ItemGroup>

<ItemGroup>
<InternalsVisibleTo Include="Microsoft.AspNetCore.Components.Analyzers.Tests" />
</ItemGroup>
</Project>
6 changes: 0 additions & 6 deletions src/Components/Analyzers/src/Properties/AssemblyInfo.cs
View file
Open in desktop

This file was deleted.

13 changes: 13 additions & 0 deletions src/Components/Components/src/Microsoft.AspNetCore.Components.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,17 @@
<NuspecProperty Include="PackageThirdPartyNoticesFile=$(PackageThirdPartyNoticesFile)" />
</ItemGroup>

<ItemGroup>
<InternalsVisibleTo Include="Microsoft.AspNetCore.Components.Web" />
<InternalsVisibleTo Include="Microsoft.AspNetCore.Blazor.Build.Tests" />
<InternalsVisibleTo Include="Microsoft.AspNetCore.Components.Authorization.Tests" />
<InternalsVisibleTo Include="Microsoft.AspNetCore.Components.Forms.Tests" />
<InternalsVisibleTo Include="Microsoft.AspNetCore.Components.Performance" />
<InternalsVisibleTo Include="Microsoft.AspNetCore.Components.Server.Tests" />
<InternalsVisibleTo Include="Microsoft.AspNetCore.Components.Tests" />
<InternalsVisibleTo Include="Microsoft.AspNetCore.Components.Web.Tests" />
<InternalsVisibleTo Include="Microsoft.AspNetCore.Components.ProtectedBrowserStorage.Tests" />
<InternalsVisibleTo Include="Components.TestServer" />
<InternalsVisibleTo Include="DynamicProxyGenAssembly2" Key="$(MoqPublicKey)" />
</ItemGroup>
</Project>
18 changes: 0 additions & 18 deletions src/Components/Components/src/Properties/AssemblyInfo.cs
View file
Open in desktop

This file was deleted.

6 changes: 6 additions & 0 deletions src/Components/Server/src/Microsoft.AspNetCore.Components.Server.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,4 +118,10 @@
<EmbeddedResource Include="$(BlazorServerJSFile).map" LogicalName="_framework/$(BlazorServerJSFilename).map" Condition="Exists('$(BlazorServerJSFile).map')" />
</ItemGroup>
</Target>

<ItemGroup>
<InternalsVisibleTo Include="Microsoft.AspNetCore.Blazor.DevServer" />
<InternalsVisibleTo Include="Microsoft.AspNetCore.Components.Server.Tests" />
<InternalsVisibleTo Include="DynamicProxyGenAssembly2" Key="$(MoqPublicKey)" />
</ItemGroup>
</Project>
9 changes: 0 additions & 9 deletions src/Components/Server/src/Properties/AssemblyInfo.cs
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions src/Components/Web/src/Microsoft.AspNetCore.Components.Web.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,8 @@
<Reference Include="System.IO.Pipelines" />
</ItemGroup>

<ItemGroup>
<InternalsVisibleTo Include="Microsoft.AspNetCore.Components.Server.Tests" />
<InternalsVisibleTo Include="Microsoft.AspNetCore.Components.Web.Tests" />
</ItemGroup>
</Project>
7 changes: 0 additions & 7 deletions src/Components/Web/src/Properties/AssemblyInfo.cs
View file
Open in desktop

This file was deleted.

3 changes: 3 additions & 0 deletions ...mbly.Authentication/src/Microsoft.AspNetCore.Components.WebAssembly.Authentication.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,4 +88,7 @@

<Import Project="Sdk.targets" Sdk="Yarn.MSBuild" Condition=" '$(DotNetBuildFromSource)' != 'true'" />

<ItemGroup>
<InternalsVisibleTo Include="Microsoft.AspNetCore.Blazor.Tests" />
</ItemGroup>
</Project>
6 changes: 0 additions & 6 deletions src/Components/WebAssembly/WebAssembly.Authentication/src/Properties/AssemblyInfo.cs
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions ...Components/WebAssembly/WebAssembly/src/Microsoft.AspNetCore.Components.WebAssembly.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,4 +63,8 @@
<Target Name="_CheckBlazorServerJSPath" BeforeTargets="GenerateNuspec" DependsOnTargets="ResolveProjectReferences" Condition=" '$(IsPackable)' == 'true' ">
<Error Text="'$(BlazorWebAssemblyJSFile)' does not exist. Enable NodeJS to pack this project." Condition=" !EXISTS('$(BlazorWebAssemblyJSFile)') " />
</Target>

<ItemGroup>
<InternalsVisibleTo Include="DynamicProxyGenAssembly2" Key="$(MoqPublicKey)" />
</ItemGroup>
</Project>
6 changes: 0 additions & 6 deletions src/Components/WebAssembly/WebAssembly/src/Properties/AssemblyInfo.cs
View file
Open in desktop

This file was deleted.

5 changes: 4 additions & 1 deletion src/DataProtection/Abstractions/src/Microsoft.AspNetCore.DataProtection.Abstractions.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<Description>ASP.NET Core data protection abstractions.
Expand All @@ -20,4 +20,7 @@ Microsoft.AspNetCore.DataProtection.IDataProtector</Description>
Condition="'$(TargetFramework)' != '$(DefaultNetCoreTargetFramework)'" />
</ItemGroup>

<ItemGroup>
<InternalsVisibleTo Include="Microsoft.AspNetCore.DataProtection.Abstractions.Tests" />
</ItemGroup>
</Project>
7 changes: 0 additions & 7 deletions src/DataProtection/Abstractions/src/Properties/AssemblyInfo.cs
View file
Open in desktop

This file was deleted.

9 changes: 9 additions & 0 deletions ...ataProtection/Cryptography.Internal/src/Microsoft.AspNetCore.Cryptography.Internal.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,13 @@
<IsTrimmable>true</IsTrimmable>
</PropertyGroup>

<ItemGroup>
<InternalsVisibleTo Include="Microsoft.AspNetCore.Cryptography.Internal.Tests" />
<InternalsVisibleTo Include="Microsoft.AspNetCore.Cryptography.KeyDerivation" />
<InternalsVisibleTo Include="Microsoft.AspNetCore.Cryptography.KeyDerivation.Tests" />
<InternalsVisibleTo Include="Microsoft.AspNetCore.DataProtection" />
<InternalsVisibleTo Include="Microsoft.AspNetCore.DataProtection.Abstractions.Tests" />
<InternalsVisibleTo Include="Microsoft.AspNetCore.DataProtection.Extensions.Tests" />
<InternalsVisibleTo Include="Microsoft.AspNetCore.DataProtection.Tests" />
</ItemGroup>
</Project>
Loading