Skip to content

Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 2067454 #45566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

dotnet-bot
Copy link
Contributor

This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/ceLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.

@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Dec 13, 2022
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 2066599 Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 2067454 Dec 14, 2022
@javiercn javiercn merged commit 232ec2e into main Dec 15, 2022
@javiercn javiercn deleted the locfiles/0b72e15a-651e-4bda-a45f-f35e57e65694 branch December 15, 2022 09:45
@dougbu
Copy link
Contributor

dougbu commented Dec 17, 2022

This should not have been merged. It reverted the translation of "here" in multiple translations. Unfortunately, comments about ignoring loc PRs were in blops issues were either themselves ignored or not carried forward as they should have been.

Even without that request, always review loc PRs very carefully.

/cc @dotnet/aspnet-build @dotnet/aspdoi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants