Fix NavigationLock throwing a JSDisconnectedException on browser close in Blazor Server #44800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TanayParikh
approved these changes
Oct 31, 2022
MackinnonBuck
added a commit
that referenced
this pull request
Oct 31, 2022
dougbu
pushed a commit
that referenced
this pull request
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
NavigationLockthrowing aJSDisconnectedExceptionon browser close in Blazor ServerFixes an issue where in Blazor Server, if the browser gets closed while a
<NavigationLock ConfirmExternalNavigation="true" />is actively rendered, aJSDisconnectedExceptiongets thrown.Description
This PR fixes the issue by catching and ignoring the
JSDisconnectedException, which is the recommended pattern for attempting to perform JS interop on component disposal.Fixes #44795