[release/7.0] [SignalR] Unblock user callbacks when waiting for client result #44014
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #43944 to release/7.0
/cc @halter73 @BrennanConroy
Unblock user callbacks when waiting for client result
This was already an issue with Task returning .On methods, but client results likely makes it more likely to block on the client side
.On
handlers but does not block the receive loop.On
handlers for future invokes/sends can still run while blocked on user input, pings/etc. still received and processed.On
handlers but does not block the receive loopFixes #41996
Customer Impact
@DavidErben writes
Regression?
No. But without this fix, client return values are not as usable with the C# and Java clients as they are with the TS/JS client.
Risk
This only affects applications taking advantage of SignalR's new client return feature.
Verification
Packaging changes reviewed?