Skip to content

[release/7.0] Continue using typeof(void) for empty TypedResults #43990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Http/Http.Results/test/AcceptedAtRouteResultTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ public void PopulateMetadata_AddsResponseTypeMetadata()
// Assert
var producesResponseTypeMetadata = builder.Metadata.OfType<ProducesResponseTypeMetadata>().Last();
Assert.Equal(StatusCodes.Status202Accepted, producesResponseTypeMetadata.StatusCode);
Assert.Equal(typeof(void), producesResponseTypeMetadata.Type);
}

[Fact]
Expand Down
4 changes: 3 additions & 1 deletion src/Http/Http.Results/test/AcceptedResultTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@ public void PopulateMetadata_AddsResponseTypeMetadata()
PopulateMetadata<Accepted>(((Delegate)MyApi).GetMethodInfo(), builder);

// Assert
Assert.Contains(builder.Metadata, m => m is ProducesResponseTypeMetadata { StatusCode: StatusCodes.Status202Accepted });
var producesResponseTypeMetadata = builder.Metadata.OfType<ProducesResponseTypeMetadata>().Last();
Assert.Equal(StatusCodes.Status202Accepted, producesResponseTypeMetadata.StatusCode);
Assert.Equal(typeof(void), producesResponseTypeMetadata.Type);
}

[Fact]
Expand Down
1 change: 1 addition & 0 deletions src/Http/Http.Results/test/BadRequestResultTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ public void PopulateMetadata_AddsResponseTypeMetadata()
// Assert
var producesResponseTypeMetadata = builder.Metadata.OfType<ProducesResponseTypeMetadata>().Last();
Assert.Equal(StatusCodes.Status400BadRequest, producesResponseTypeMetadata.StatusCode);
Assert.Equal(typeof(void), producesResponseTypeMetadata.Type);
}

[Fact]
Expand Down
1 change: 1 addition & 0 deletions src/Http/Http.Results/test/ConflictResultTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ public void PopulateMetadata_AddsResponseTypeMetadata()
// Assert
var producesResponseTypeMetadata = builder.Metadata.OfType<ProducesResponseTypeMetadata>().Last();
Assert.Equal(StatusCodes.Status409Conflict, producesResponseTypeMetadata.StatusCode);
Assert.Equal(typeof(void), producesResponseTypeMetadata.Type);
}

[Fact]
Expand Down
1 change: 1 addition & 0 deletions src/Http/Http.Results/test/CreatedAtRouteResultTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ public void PopulateMetadata_AddsResponseTypeMetadata()
// Assert
var producesResponseTypeMetadata = builder.Metadata.OfType<ProducesResponseTypeMetadata>().Last();
Assert.Equal(StatusCodes.Status201Created, producesResponseTypeMetadata.StatusCode);
Assert.Equal(typeof(void), producesResponseTypeMetadata.Type);
}

[Fact]
Expand Down
1 change: 1 addition & 0 deletions src/Http/Http.Results/test/CreatedResultTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ public void PopulateMetadata_AddsResponseTypeMetadata()
// Assert
var producesResponseTypeMetadata = builder.Metadata.OfType<ProducesResponseTypeMetadata>().Last();
Assert.Equal(StatusCodes.Status201Created, producesResponseTypeMetadata.StatusCode);
Assert.Equal(typeof(void), producesResponseTypeMetadata.Type);
}

[Fact]
Expand Down
1 change: 1 addition & 0 deletions src/Http/Http.Results/test/NoContentResultTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ public void PopulateMetadata_AddsResponseTypeMetadata()
// Assert
var producesResponseTypeMetadata = builder.Metadata.OfType<ProducesResponseTypeMetadata>().Last();
Assert.Equal(StatusCodes.Status204NoContent, producesResponseTypeMetadata.StatusCode);
Assert.Equal(typeof(void), producesResponseTypeMetadata.Type);
}

[Fact]
Expand Down
1 change: 1 addition & 0 deletions src/Http/Http.Results/test/NotFoundResultTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ public void PopulateMetadata_AddsResponseTypeMetadata()
// Assert
var producesResponseTypeMetadata = builder.Metadata.OfType<ProducesResponseTypeMetadata>().Last();
Assert.Equal(StatusCodes.Status404NotFound, producesResponseTypeMetadata.StatusCode);
Assert.Equal(typeof(void), producesResponseTypeMetadata.Type);
}

[Fact]
Expand Down
1 change: 1 addition & 0 deletions src/Http/Http.Results/test/OkResultTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ public void PopulateMetadata_AddsResponseTypeMetadata()
// Assert
var producesResponseTypeMetadata = builder.Metadata.OfType<ProducesResponseTypeMetadata>().Last();
Assert.Equal(StatusCodes.Status200OK, producesResponseTypeMetadata.StatusCode);
Assert.Equal(typeof(void), producesResponseTypeMetadata.Type);
}

[Fact]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ public void PopulateMetadata_AddsResponseTypeMetadata()
// Assert
var producesResponseTypeMetadata = builder.Metadata.OfType<ProducesResponseTypeMetadata>().Last();
Assert.Equal(StatusCodes.Status422UnprocessableEntity, producesResponseTypeMetadata.StatusCode);
Assert.Equal(typeof(void), producesResponseTypeMetadata.Type);
}

[Fact]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ internal sealed class ProducesResponseTypeMetadata : IProducesResponseTypeMetada
/// </summary>
/// <param name="statusCode">The HTTP response status code.</param>
public ProducesResponseTypeMetadata(int statusCode)
: this(type: null, statusCode, Enumerable.Empty<string>())
: this(typeof(void), statusCode, Enumerable.Empty<string>())
{
}

Expand Down