Skip to content

CanCachePolicy=>AllowsCachingPolicies #43479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2022
Merged

CanCachePolicy=>AllowsCachingPolicies #43479

merged 1 commit into from
Aug 23, 2022

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Aug 23, 2022 •
edited
Loading

React to API review: #43227

We added a new API last week, and this is just renaming the new property to a better name which came out of the API review for this feature.

@HaoK HaoK requested a review from Tratcher as a code owner August 23, 2022 00:31
@ghost ghost added the area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer label Aug 23, 2022
@HaoK HaoK requested review from Pilchie, halter73, a team and captainsafia August 23, 2022 00:31
@HaoK
Copy link
Member Author

HaoK commented Aug 23, 2022

@dotnet/aspnet-build do I need to worry about the code check API files failing?

@HaoK HaoK added the ask-mode This issue / PR is a patch candidate which we will bar-check internally before patching it. label Aug 23, 2022
@wtgodbe
Copy link
Member

wtgodbe commented Aug 23, 2022

https://github.com/orgs/dotnet/teams/aspnet-build do I need to worry about the code check API files failing?

No, that's expected for changing API in release branches. If this gets servicing-approved one of us will just force-merge it.

@adityamandaleeka
Copy link
Member

Approved. This is brand new API.

@dougbu
Copy link
Contributor

dougbu commented Aug 23, 2022

Approved. This is brand new API.

Thanks @adityamandaleeka. Suggest using the servicing-approved label to make this visible in PR lists 😉

@dougbu dougbu merged commit 63fb7a8 into release/7.0-rc1 Aug 23, 2022
@dougbu dougbu deleted the haok/ren3 branch August 23, 2022 18:31
halter73 pushed a commit to halter73/AspNetCore that referenced this pull request Nov 20, 2024
@HaoK @halter73
CanCachePolicy=>AllowsCachingPolicies (dotnet#43479)
48d0394
@renatoklypz
Copy link

I don't understand why the AllowsCachingPolicies property is only available in NETCOREAPP #if NETCOREAPP, if you are using it in the middleware in a mandatory way. When you run an API unit test (using WebApplicationFactory), the property is not found, throwing an exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfowl davidfowl davidfowl approved these changes

@captainsafia captainsafia captainsafia approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

@Pilchie Pilchie Awaiting requested review from Pilchie

@halter73 halter73 Awaiting requested review from halter73

Assignees
No one assigned
Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer ask-mode This issue / PR is a patch candidate which we will bar-check internally before patching it.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@HaoK @wtgodbe @adityamandaleeka @dougbu @renatoklypz @davidfowl @captainsafia