Nullable cleanup #43451
Merged
Nullable cleanup #43451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
captainsafia,
halter73 and
Pilchie
as code owners
JamesNK
commented
Aug 22, 2022
| @@ -7,7 +7,6 @@ | |||
| <RootNamespace>Microsoft.Extensions.ApiDescription.Tool</RootNamespace> | |||
| <TargetFrameworks>netcoreapp2.1;$(DefaultNetFxTargetFramework)</TargetFrameworks> | |||
| <IsShippingPackage>false</IsShippingPackage> | |||
| <Nullable>disable</Nullable> | |||
There was a problem hiding this comment.
props file in tools directory already disables nullability.
src/HttpClientFactory/Polly/src/Microsoft.Extensions.Http.Polly.csproj
Outdated
Show resolved
Hide resolved
| @@ -6,6 +6,7 @@ | |||
| <CopySymbolsToArtifacts>true</CopySymbolsToArtifacts> | |||
| <IsPackable>false</IsPackable> | |||
| <IsShippingPackage>false</IsShippingPackage> | |||
| <!-- Nullable disabled because package only targets .NET Framework. --> | |||
There was a problem hiding this comment.
This one should be easy, it's a single file 😄
JamesNK
force-pushed
the
jamesnk/nullable-cleanup
branch
from
3c6d72b to
6848495
Compare
Pilchie
added
the
old-area-web-frameworks-do-not-use
BrennanConroy
approved these changes
Aug 25, 2022
captainsafia
approved these changes
Aug 31, 2022
JamesNK
force-pushed
the
jamesnk/nullable-cleanup
branch
from
6848495 to
61a578f
Compare
JamesNK
force-pushed
the
jamesnk/nullable-cleanup
branch
from
61a578f to
94be653
Compare
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5680