Skip to content

Exclusively use Azure (public) feeds #43303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 17, 2022
Merged

Exclusively use Azure (public) feeds #43303

merged 4 commits into from
Aug 17, 2022

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Aug 15, 2022

No description provided.

@dougbu dougbu requested a review from a team August 15, 2022 17:31
wtgodbe
wtgodbe reviewed Aug 15, 2022
View reviewed changes
@BrennanConroy
Copy link
Member

Didn't you say .npmrc doesn't work with yarn?

@dougbu
Copy link
Contributor Author

dougbu commented Aug 15, 2022

Didn't you say .npmrc doesn't work with yarn?

I thought it didn't but everything was fine locally.

@dougbu dougbu added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Aug 16, 2022
@ghost
Copy link

ghost commented Aug 16, 2022

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@dougbu dougbu force-pushed the dougbu/central.feed branch from e73309f to 66f9ce7 Compare August 16, 2022 19:20
@dougbu dougbu enabled auto-merge (squash) August 16, 2022 19:23
@dougbu dougbu changed the title Add npmrc files Exclusively use Azure (public) feeds Aug 16, 2022
@dougbu
Copy link
Contributor Author

dougbu commented Aug 16, 2022

@mmitche will we need a change like this in release/7.0❔ If yes, what about release/7.0-rc1❔

@dougbu
Copy link
Contributor Author

dougbu commented Aug 16, 2022

I recall the current emphasis is on our default branch but want to confirm.

@BrennanConroy
Copy link
Member

Can you explain what we need to do now with regards to npm dependencies, email is fine.

mmitche
mmitche reviewed Aug 16, 2022
View reviewed changes
mmitche
mmitche requested changes Aug 16, 2022
View reviewed changes
Copy link
Member

@mmitche mmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the always_auth params should be removed, but otherwise looks good

@dougbu
Copy link
Contributor Author

dougbu commented Aug 16, 2022

Thanks @mmitche, I'll remove the required auth in the next iteration here.

Separately, this PR seems to add .npmrc files to the npm packages we ship. That doesn't seem right. How would I change package.json files to exclude .npmrc from what we ship @javiercn @BrennanConroy❔

@dougbu
Copy link
Contributor Author

dougbu commented Aug 16, 2022

Separately, this PR seems to add .npmrc files to the npm packages we ship. That doesn't seem right. How would I change package.json files to exclude .npmrc from what we ship @javiercn @BrennanConroy❔

Never mind. Turns out all that happens is .npmrc files get copied to our node_modules/ folders when you do a local build. Final *.tgz files aren't changing here 😀

@dougbu
Copy link
Contributor Author

dougbu commented Aug 16, 2022

@BrennanConroy @TanayParikh @javiercn and anyone else who knows our local npm references: I have been yarn installing and occasionally yarn building locally. These steps added "microsoft.aspnetcore.components.e2etest": "file:" under dependencies in src/Components/test/E2ETest/package.json. Should I update this PR to include that change❔

@dougbu dougbu force-pushed the dougbu/central.feed branch from 66f9ce7 to e858f91 Compare August 16, 2022 23:21
@dougbu dougbu disabled auto-merge August 16, 2022 23:22
@dougbu dougbu enabled auto-merge (squash) August 16, 2022 23:23
@dougbu
Copy link
Contributor Author

dougbu commented Aug 16, 2022

Can you explain what we need to do now with regards to npm dependencies, email is fine.

sent

@dougbu dougbu disabled auto-merge August 17, 2022 00:03
@dougbu dougbu enabled auto-merge (squash) August 17, 2022 00:04
dougbu added 3 commits August 17, 2022 10:49
@dougbu
Correct ref to selenium-config.json
8814ebf 
- fix what broke `yarn install` in these directories
@dougbu
Update a yarn.lock file
e4c390f
@dougbu
Use yarn in aspnetcore-components-e2e pipeline
e073a6a 
- also correct a missing `--frozen-lockfile`
@dougbu dougbu force-pushed the dougbu/central.feed branch from 2020a7f to e073a6a Compare August 17, 2022 18:41
@dougbu dougbu disabled auto-merge August 17, 2022 21:27
@dougbu dougbu enabled auto-merge (squash) August 17, 2022 21:27
@dougbu dougbu requested review from mmitche and wtgodbe August 17, 2022 21:28
@dougbu
Copy link
Contributor Author

dougbu commented Aug 17, 2022

@mmitche I addressed your concern about requiring auth.

@wtgodbe this PR is fairly different from what you approved.

@dougbu dougbu merged commit 48a81a7 into dotnet:main Aug 17, 2022
@dougbu dougbu deleted the dougbu/central.feed branch August 17, 2022 22:02
@ghost ghost added this to the 8.0-alpha1 milestone Aug 17, 2022
@dougbu dougbu mentioned this pull request Aug 18, 2022
Merged
dougbu added a commit that referenced this pull request Aug 18, 2022
@dougbu
Backport parts of 48a81a7 (#43357)
f2629ce 
- was "Exclusively use Azure (public) feeds (#43303)"
- Correct ref to selenium-config.json
  - fix what broke `yarn install` in these directories
- Use `yarn` in aspnetcore-components-e2e pipeline
  - also correct a missing `--frozen-lockfile`

Co-authored-by: MerlinBot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmitche mmitche mmitche approved these changes

@wtgodbe wtgodbe wtgodbe approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@Tratcher Tratcher Awaiting requested review from Tratcher

@Pilchie Pilchie Awaiting requested review from Pilchie

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
8.0-preview1
Development

Successfully merging this pull request may close these issues.
4 participants
@dougbu @BrennanConroy @mmitche @wtgodbe