Skip to content

Fix check for auth services in middleware auto-registration #43205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

captainsafia
Copy link
Member

Closes #43188.

@captainsafia captainsafia added the old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels label Aug 11, 2022
@captainsafia captainsafia requested review from davidfowl and HaoK August 11, 2022 00:32
{
var builder = WebApplication.CreateBuilder(new WebApplicationOptions()
{
EnvironmentName = Environments.Development
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent scopes on resolved services only get validated in Development so we set the environment name explicitly here to validate the broken behavior.

@captainsafia captainsafia enabled auto-merge (squash) August 11, 2022 02:07
@captainsafia captainsafia merged commit efb694c into main Aug 11, 2022
@captainsafia captainsafia deleted the safia/authz-fix branch August 11, 2022 02:44
@ghost ghost added this to the 7.0-rc1 milestone Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot add scoped AuthorizationHandler in .NET 7 Preview 7
3 participants