Trim Microsoft.AspNetCore #42555
Merged
Trim Microsoft.AspNetCore #42555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
Tratcher,
halter73,
a team,
dougbu,
wtgodbe and
Pilchie
as code owners
|
Review please 🙏 |
davidfowl
reviewed
Jul 6, 2022
| @@ -173,7 +173,7 @@ IWebHostBuilder ISupportsStartup.Configure(Action<WebHostBuilderContext, IApplic | |||
| throw new NotSupportedException("Configure() is not supported by WebApplicationBuilder.WebHost. Use the WebApplication returned by WebApplicationBuilder.Build() instead."); | |||
| } | |||
|
|
|||
| IWebHostBuilder ISupportsStartup.UseStartup(Type startupType) | |||
| IWebHostBuilder ISupportsStartup.UseStartup([DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors | DynamicallyAccessedMemberTypes.PublicMethods)] Type startupType) | |||
There was a problem hiding this comment.
I'd go the other way and just delete StartupLinkerOptions. This is simple enough I like just seeing the flags defined inline.
There was a problem hiding this comment.
Maybe? I guess this will never change so its not a big deal.
halter73
approved these changes
Jul 6, 2022
| @@ -173,7 +173,7 @@ IWebHostBuilder ISupportsStartup.Configure(Action<WebHostBuilderContext, IApplic | |||
| throw new NotSupportedException("Configure() is not supported by WebApplicationBuilder.WebHost. Use the WebApplication returned by WebApplicationBuilder.Build() instead."); | |||
| } | |||
|
|
|||
| IWebHostBuilder ISupportsStartup.UseStartup(Type startupType) | |||
| IWebHostBuilder ISupportsStartup.UseStartup([DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors | DynamicallyAccessedMemberTypes.PublicMethods)] Type startupType) | |||
There was a problem hiding this comment.
I'd go the other way and just delete StartupLinkerOptions. This is simple enough I like just seeing the flags defined inline.
JamesNK
force-pushed
the
jamesnk/defaultbuilder
branch
from
49eeea8 to
a2db098
Compare
davidfowl
approved these changes
Jul 7, 2022
|
So, what all gets trimmed with this? |
ghost
added this to the 
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.