Skip to content

Allow file middlewares to run if there's an endpoint with a null request delegate #42415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 17 commits into from
Closed

Allow file middlewares to run if there's an endpoint with a null request delegate #42415

wants to merge 17 commits into from

Conversation

DamianEdwards
Copy link
Member

Fixes #42413

@DamianEdwards DamianEdwards linked an issue Jun 24, 2022 that may be closed by this pull request
Change DefaultFiles/DirectoryBrowser/StaticFileMiddleware to only no-op if there's an active endpoint with a non-null RequestDelegate #42413
Closed
@ghost ghost added the area-runtime label Jun 24, 2022
DamianEdwards and others added 16 commits June 24, 2022 15:30
@DamianEdwards
Ensure EndpointMiddleware checks AuthZ/CORS metadata even if endpoint…
2005ad4 
….RequestDelegate is null
@DamianEdwards
Update null equality check to use "is"
eb12d02
@dependabot
Bump got in /src/ProjectTemplates/test/Templates.Tests (#42405)
ddef2f6 
Bumps [got](https://github.com/sindresorhus/got) from 11.8.3 to 11.8.5.
- [Release notes](https://github.com/sindresorhus/got/releases)
- [Commits](sindresorhus/got@v11.8.3...v11.8.5)

---
updated-dependencies:
- dependency-name: got
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@adityamandaleeka
Fix event name for the shutdown event in hosting. (#42414)
0e5cbf4
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2022…
082e718 
…0624.7 (#42424)

[main] Update dependencies from dotnet/runtime
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2022…
88bf941 
…0625.3 (#42430)

[main] Update dependencies from dotnet/runtime
@javiercn
[Blazor] Unquarantine component E2E tests that were quarantined becau…
868320e 
…se of an SDK issue (#41494)

Fixes #41425 that marked the tests as quarantined because of a runtime issue that was blocking the SDK update. 

A fix was merged on the runtime and the SDK was updated, so these tests should go back to normal.
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2022…
f35d229 
…0626.1 (#42441)

[main] Update dependencies from dotnet/runtime
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20220…
b542f2f 
…627.1 (#42442)

[main] Update dependencies from dotnet/arcade
@dependabot
[main] (deps): Bump src/submodules/googletest (#42440)
2cfadbb 
Bumps [src/submodules/googletest](https://github.com/google/googletest) from `86add13` to `5376968`.
- [Release notes](https://github.com/google/googletest/releases)
- [Commits](google/googletest@86add13...5376968)

---
updated-dependencies:
- dependency-name: src/submodules/googletest
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @dougbu
Bump node-fetch from 2.6.1 to 2.6.7 in /src/SignalR/clients/ts/Functi…
0db136d 
…onalTests (#42427)

* Bump node-fetch in /src/SignalR/clients/ts/FunctionalTests

Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.1 to 2.6.7.
- [Release notes](https://github.com/node-fetch/node-fetch/releases)
- [Commits](node-fetch/node-fetch@v2.6.1...v2.6.7)

---
updated-dependencies:
- dependency-name: node-fetch
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* Undo changes for local `npm` dependencies
- apply suggestions from code review

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Doug Bunting <[email protected]>
@DamianEdwards
Allow file middlewares to run if there's an endpoint with a null requ…
7416f71 
…est delegate #42413
@DamianEdwards
Ensure EndpointMiddleware checks AuthZ/CORS metadata even if endpoint…
83160ec 
….RequestDelegate is null
@DamianEdwards
Update null equality check to use "is"
c653f54
@DamianEdwards
Added tests for StaticFileMiddleware changes
510630a
@DamianEdwards
Merge branch '42413-staticfiles-nullrequestdelegate' of https://githu…
16da4cd 
…b.com/dotnet/aspnetcore into 42413-staticfiles-nullrequestdelegate
@DamianEdwards
Copy link
Member Author

Closing in favor of #42458

@amcasey amcasey added area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtgodbe wtgodbe Awaiting requested review from wtgodbe wtgodbe will be requested when the pull request is marked ready for review wtgodbe is a code owner

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy will be requested when the pull request is marked ready for review BrennanConroy is a code owner

@halter73 halter73 Awaiting requested review from halter73 halter73 will be requested when the pull request is marked ready for review halter73 is a code owner

Assignees
No one assigned
Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change DefaultFiles/DirectoryBrowser/StaticFileMiddleware to only no-op if there's an active endpoint with a non-null RequestDelegate
4 participants
@DamianEdwards @amcasey @adityamandaleeka @javiercn