Fix VS only warning #39614
Merged
Fix VS only warning #39614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
pranavkm
approved these changes
Jan 18, 2022
|
Weird it didn't show up in the CLI build. |
Tratcher
reviewed
Jan 19, 2022
| @@ -144,7 +144,7 @@ public bool ParseHeaders(TRequestHandler handler, ref SequenceReader<byte> reade | |||
| var span = reader.UnreadSpan; | |||
| while (span.Length > 0) | |||
| { | |||
| var ch1 = (byte)0; | |||
| byte ch1; | |||
| var ch2 = (byte)0; | |||
There was a problem hiding this comment.
why did it only change ch1 and not ch2?
There was a problem hiding this comment.
ch2 isn't always set in the below code, ch1 is because of the TryRead in the else if
Does anyone have a theory why it didn't? |
|
Potentially dotnet/roslyn#58807 |
|
@halter73 we tried digging in to this. At least on my 17.1 p2 builds of VS, I did not see this error. VS ships with a different instance of the compiler than the SDK, so it might be that the build that @BrennanConroy has includes these changes, but not the SDK. |
ShreyasJejurkar
pushed a commit
to ShreyasJejurkar/aspnetcore
that referenced
this pull request
Jan 22, 2022
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aspnetcore/.editorconfig
Lines 233 to 234 in 1ca0709