Use default if no value was bound for parameter #39427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-mvc
pranavkm
reviewed
Jan 11, 2022
| @@ -546,7 +546,7 @@ private Task BindArgumentsAsync() | |||
| { | |||
| var parameterInfo = declaredParameterInfos[index]; | |||
|
|
|||
| if (!actionParameters.TryGetValue(parameterInfo.Name!, out var value)) | |||
| if (!actionParameters.TryGetValue(parameterInfo.Name!, out var value) || value is null) | |||
There was a problem hiding this comment.
This change feels innocuous enough, but do we know why this is needed? The code around here hasn't changed in ages.
There was a problem hiding this comment.
The original issue reported the regression between .NET 5 and .NET 6. I was able to verify it as well. A quick peruse of the commit logs has me suspicious about some of the nullability changes that we made in this area for 6.0-preview4 but I, admittedly, haven't dug deeper. 🤷🏽♀️
pranavkm
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38440