Add EmptyContent to Virtualize #38978
Conversation
ghost
added
area-blazor
| /// Gets or sets the empty content. | ||
| /// </summary> | ||
| [Parameter] | ||
| public RenderFragment? EmptyContent { get; set; } |
There was a problem hiding this comment.
Could you follow the instructions here: https://github.com/dotnet/aspnetcore/blob/main/docs/APIBaselines.md#publicapiunshippedtxt?
There was a problem hiding this comment.
Yes sir. I missed that part of the instructions.
| @@ -193,6 +199,11 @@ protected override void BuildRenderTree(RenderTreeBuilder builder) | |||
|
|
|||
| builder.OpenRegion(3); | |||
|
|
|||
| if (EmptyContent is not null && _itemCount == 0) | |||
There was a problem hiding this comment.
Wouldn't this show the empty content when the list is still being loaded in the event the data source is an ItemsProvider? That doesn't seem right.
Could we also add some tests for this?
There was a problem hiding this comment.
You're right, it indeed does. I will rectify that and write some tests.
pranavkm
added
the
pr: pending author input
Co-authored-by: Pranav K <[email protected]>
|
Hi @alex-oswald. |
ghost
added
the
stale
|
No work plans during the holidays. If you need to close this to keep it clean that’s cool. I can reopen after the holidays when I finish the work. |
No worries, it's just an automated process. Feel free to reopen whenever you're ready 😀 |
ghost
closed this
Add EmptyContent to Virtualize component
Description
This PR adds an
EmptyContentfragment to the virtualize component. If there are no items to render, and the fragment is not null, the fragment is rendered.This is useful because as it stands, if there are no items to render, nothing is rendered, potentially leaving a user confused.
Implements: #28770