[release/6.0] <TargetFrameworks /> -> <TargetFramework />
#37121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- backport of #36727 `<TargetFrameworks />` -> `<TargetFramework />` (#36727) * `<TargetFrameworks />` -> `<TargetFramework />` - avoid useless transitions to inner builds * Remove most `$(BenchmarksTargetFramework)` use Co-authored-by: Sébastien Ros <[email protected]>
dougbu
added
area-infrastructure
dougbu
requested review from
BrennanConroy,
halter73,
javiercn,
Pilchie,
pranavkm,
Tratcher and
a team
as code owners
dougbu
commented
Sep 30, 2021
| @@ -36,7 +36,7 @@ public string GetTempSecretProject() | |||
| private const string ProjectTemplate = @"<Project ToolsVersion=""15.0"" Sdk=""Microsoft.NET.Sdk""> | |||
| <PropertyGroup> | |||
| <OutputType>Exe</OutputType> | |||
| <TargetFrameworks>net6.0</TargetFrameworks> | |||
| <TargetFramework>net6.0</TargetFramework> | |||
There was a problem hiding this comment.
/fyi this group of backports has been clean except for this one line 🎉
sebastienros
approved these changes
Sep 30, 2021
|
Why is this important for 6.0? |
wtgodbe
approved these changes
Sep 30, 2021
It's basically free and removes some build complications that we'd rather not live w/ forever. Might even improve build performance too. |
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<TargetFrameworks />-><TargetFramework />#36727<TargetFrameworks />-><TargetFramework />(#36727)<TargetFrameworks />-><TargetFramework />$(BenchmarksTargetFramework)useCo-authored-by: Sébastien Ros [email protected]