Always download blazor-hotreload.js from app root #36862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The middleware that we inject always listens to the root of the app. While this might not play very nicely if the app is running off a virtual path, listening to the root is what we do with the aspnet-browser-refresh.js script and we've had no issue reports with it thus far. Fixes #35555
ghost
added
the
|
@Pilchie for 6.0 consideration. I missed porting this change over to rc2 when I initially made this. Did a quick scan to verify other changes that I made for rc2 are actually there. |
|
Approved for .NET Core 6.0. |
javiercn
approved these changes
Sep 23, 2021
|
@dotnet/aspnet-build requesting merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port #35737 to release/6.0
Description
Hot reload for WebAssembly attempts to download a JS script as part of booting up the app which is served from the root of the app (e.g.
/_framework/blazor-hotreload.js). Blazor constructs a URL for the script and downloads it. Currently this URL is relative to where Blazor is hosted. Blazor also allows a way to configure it to be served from a subdirectory of the app root. In this case, the URL for the script is incorrectly constructed (e.g./mycustomsubdir/_framework/blazor-hotreload.js) which causes the app to fail loading.Regression
No.
Testing
The change was manually tested.
Risk
There's a very uncommon scenario where the user does additional work to host the entire app of a virtual subdirectory which this change regresses. However, other scripts scripts that VS injects in to the app (browser-link for css updates) are already broken in this case so we're not making things significantly worse.
Issues
Fixes #35555
Fixes #35967