Cherry-pick mismatched parameter optionality analyzer and clean up directories #36379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…36154) * Add analyzer for detecting mismatched endpoint parameter optionality * Address feedback from code review * Factor out CodeFixes and Analyzers to separate assemblies * Address more feedback from review * Address code checks
captainsafia
requested review from
dougbu,
Pilchie and
a team
as code owners
dougbu
reviewed
Sep 10, 2021
.../AspNetCoreAnalyzers/src/Analyzers/DelegateEndpoints/DetectMismatchedParameterOptionality.cs
Outdated
Show resolved
Hide resolved
src/Framework/AspNetCoreAnalyzers/src/Analyzers/DelegateEndpoints/DiagnosticDescriptors.cs
Outdated
Show resolved
Hide resolved
MackinnonBuck
approved these changes
Sep 10, 2021
dougbu
reviewed
Sep 10, 2021
Co-authored-by: Doug Bunting <[email protected]>
dougbu
reviewed
Sep 13, 2021
There was a problem hiding this comment.
No further objections from me. Worst thing I could nitpick about (but won't 😀) is utility of trailing commas in array initializers to minimize perceived churn later. I'm not chiming in on approvals w/ @MackinnonBuck because I didn't really delve into the C#
|
@dougbu Sounds good. I think I'll need a approval from you since @MackinnonBuck has left the GitHub org. |
Pilchie
added
the
old-area-web-frameworks-do-not-use
dougbu
approved these changes
Sep 14, 2021
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks #36154 to main and cleans up the folders in the Analyzers directory now that we have both components and minimal APIs analyzers in here.