-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Retarget DOTNETHOME when installing x64 on ARM64 #36100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I don't think GitHub will notify us when this PR is ready for review. Could you please let us know @ericstj❔ |
Sure, I'll let you know, mostly I just need to wait until the arcade change is reviewed and then replicate feedback here. One thing that's unique to ASP.NET is this: https://github.com/dotnet/aspnetcore/pull/36100/files#diff-b146853a2811958d2332489ea0501ea790ed1df7061172676d9c65a143d499b9R70 Can you have a look and let me know what you think? |
@wtgodbe or @joeloff, I think you have more context to answer @ericstj's question about https://github.com/dotnet/aspnetcore/pull/36100/files#diff-841d5a29fed63d4cad2012857ad278859c9fbfdb19a78c6899af34c6155d34daR69-R72 @ericstj on the other hand, we avoid |
I'm not going to commit it. It's in this PR while in draft because I need feedback from ASP.NET about it. I intend to get your feedback to address that comment and remove before committing. |
This should now be ready for review. Note that I resolved the clashing registry keys between x64 and arm64 by making x64 install to a different path on ARM64 machines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe I responded to all feedback, reviewers, can you please have a look at the responses and let me know if this looks good? |
@ericstj do we need this fix in release/6.0❔ If yes, release/6.0-rc2 as well❔ |
Yes, I will be bringing a long list of commits to port to 6.0-rc2 |
Hi @ericstj. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
/backport to release/6.0-rc2 |
Hi @ericstj. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
Started backporting to release/6.0-rc2: https://github.com/dotnet/aspnetcore/actions/runs/1247487572 |
Draft that enables installing x64 product on ARM64.
Related PRs:
dotnet/arcade#7785
dotnet/runtime#58669
dotnet/installer#11843