Skip to content

Add support for stating accepts/consumes metadata is required or not #35875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Sep 3, 2021
Merged

Add support for stating accepts/consumes metadata is required or not #35875

merged 19 commits into from
Sep 3, 2021

Conversation

rafikiassumani-msft
Copy link
Contributor

PR Title
Add support for stating accepts/consumes metadata is required or not

PR Description
This PR uses AcceptsMetata for extensions method rather ConsumesAttribute

Fixes #35849

@rafikiassumani-msft rafikiassumani-msft marked this pull request as draft August 28, 2021 02:15
DamianEdwards
DamianEdwards requested changes Aug 28, 2021
View reviewed changes
Kahbazi
Kahbazi reviewed Aug 28, 2021
View reviewed changes
pranavkm
pranavkm reviewed Aug 28, 2021
View reviewed changes
@rafikiassumani-msft rafikiassumani-msft marked this pull request as ready for review August 30, 2021 03:34
@Pilchie Pilchie added the old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels label Aug 30, 2021
DamianEdwards
DamianEdwards reviewed Aug 30, 2021
View reviewed changes
pranavkm
pranavkm reviewed Aug 30, 2021
View reviewed changes
DamianEdwards
DamianEdwards reviewed Aug 30, 2021
View reviewed changes
DamianEdwards
DamianEdwards reviewed Aug 30, 2021
View reviewed changes
DamianEdwards
DamianEdwards reviewed Aug 30, 2021
View reviewed changes
@rafikiassumani-msft rafikiassumani-msft added this to the 6.0-rc2 milestone Aug 30, 2021
Kahbazi
Kahbazi reviewed Aug 30, 2021
View reviewed changes
pranavkm
pranavkm approved these changes Aug 30, 2021
View reviewed changes
@rafikiassumani-msft rafikiassumani-msft enabled auto-merge (squash) September 1, 2021 17:41
davidfowl
davidfowl reviewed Sep 3, 2021
View reviewed changes
Kahbazi
Kahbazi reviewed Sep 3, 2021
View reviewed changes
@rafikiassumani-msft
Copy link
Contributor Author

/backport to release/6.0

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2021

Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1199180364

@github-actions github-actions bot mentioned this pull request Sep 3, 2021
Merged
@rafikiassumani-msft rafikiassumani-msft merged commit d9ac5f4 into dotnet:main Sep 3, 2021
@ghost ghost modified the milestones: 6.0-rc2, 7.0-preview1 Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halter73 halter73 halter73 left review comments

@pranavkm pranavkm pranavkm approved these changes

@DamianEdwards DamianEdwards DamianEdwards requested changes

@Kahbazi Kahbazi Kahbazi left review comments

@davidfowl davidfowl davidfowl approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@javiercn javiercn Awaiting requested review from javiercn

@Pilchie Pilchie Awaiting requested review from Pilchie

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees
No one assigned
Labels
old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels
Projects
None yet
Milestone
7.0-preview1
Development

Successfully merging this pull request may close these issues.

Add support for stating accepts/consumes metadata is required or not
7 participants
@rafikiassumani-msft @halter73 @davidfowl @pranavkm @DamianEdwards @Kahbazi @Pilchie