Skip to content

Remove unusued using statement (fixes #35840) #35841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 30, 2021
Merged

Remove unusued using statement (fixes #35840) #35841

merged 2 commits into from
Aug 30, 2021

Conversation

timheuer
Copy link
Member

PR Title
Remove unused using statement in template

PR Description
Removing unused using Microsoft.OpenApi.Models statement that no longer is needed in default template and removes Roslyn code-fix suggestion

Fixes #35840

@timheuer timheuer requested a review from Pilchie as a code owner August 27, 2021 17:33
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Aug 27, 2021
@timheuer timheuer requested a review from DamianEdwards August 27, 2021 20:10
Copy link
Member

@Pilchie Pilchie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but we should get someone who knows the templates better to look too. @javiercn, you're probably the best person.

@timheuer I assume you want this to ship for .NET 6?

@timheuer
Copy link
Member Author

@timheuer I assume you want this to ship for .NET 6?
Yeah would be good for new template not to generate tooling warnings out of the box if we can avoid.

@timheuer timheuer requested a review from javiercn August 27, 2021 21:44
@DamianEdwards
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@DamianEdwards DamianEdwards merged commit ad5cc24 into dotnet:main Aug 30, 2021
@ghost ghost added this to the 7.0-preview1 milestone Aug 30, 2021
@DamianEdwards
Copy link
Member

/backport to release/6.0

@ghost
Copy link

ghost commented Aug 30, 2021

Hi @DamianEdwards. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@github-actions
Copy link
Contributor

Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1183877565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New templates have unnecessary using statement for OpenApi
3 participants