Fix keyboard input for 'time' and 'datetime-local' inputs #35682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
MackinnonBuck
commented
Aug 25, 2021
| @@ -271,7 +271,7 @@ public void InputDateInteractsWithEditContext_TimeInput() | |||
| Browser.Equal(new[] { "The DepartureTime field must be a time." }, messagesAccessor); | |||
| } | |||
|
|
|||
| [Fact(Skip = "https://github.com/dotnet/aspnetcore/issues/35498")] | |||
There was a problem hiding this comment.
While these tests used to fail reliably, they now pass reliably when run locally, so they're no longer being skipped (the issue linked is the one that this PR is claiming to fix, anyway).
pranavkm
approved these changes
Aug 25, 2021
|
Happy with the code changes. Let's add a couple of tests and we should be good to go! |
TanayParikh
approved these changes
Aug 25, 2021
MackinnonBuck
added a commit
that referenced
this pull request
Aug 25, 2021
wtgodbe
pushed a commit
that referenced
this pull request
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix keyboard input for
timeanddatetime-localinputsThis PR fixes the unusual behavior observed when using keyboard input with
<input type="time" />and<input type="datetime-local" />.PR Description
The root cause of the issue came down to the acceptable time format for time-based inputs when the seconds part of the string reads ":00". As it turns out, the seconds value must be omitted unless it contains a value other than ":00", otherwise pending keyboard input starts misbehaving (e.g. jumping to the next time quantity prematurely or always modifying the least-significant digit of the current time quantity).
This behavior had previously been observed with
datetime-local, but I was able to reproduce the same issue withtimeifstep="1"and the initial seconds value was ":00". We already had logic that removed seconds from the value fortimeinputs when no step was specified, but that didn't account for the keyboard input bug completely.Validation
stepattribute values and seconds valuesFixes #35498