Update templates to use scoped CSS #35658
Conversation
ghost
added
the
area-mvc
captainsafia
force-pushed
the
safia/css-templates
branch
from
66a0a2a to
a0c532c
Compare
captainsafia
force-pushed
the
safia/css-templates
branch
from
a0c532c to
c51712c
Compare
| "Pages/Shared/_LoginPartial.cshtml", | ||
| "Pages/Shared/_ValidationScriptsPartial.cshtml", | ||
| "Properties/launchSettings.json", | ||
| "wwwroot/favicon.ico", | ||
| "wwwroot/css/site.css", |
There was a problem hiding this comment.
Do we want to keep a stub site.css file in the template or should we completely move over? We can probably keep the html and @media related styles in the site.css file but not sure how all-or-nothing we wanted to be about the migration.
There was a problem hiding this comment.
I think we should keep it, it gives folks a place to put regular/global CSS.
There was a problem hiding this comment.
We generally don't ship empty files though. Particularly not one that isn't referenced by the app. Let's remove this, users can always add one back if they want to.
There was a problem hiding this comment.
We generally don't ship empty files though.
They won't be empty in this case. I just moved the top-level styles targeting html and body to them. I think that's a good middle-ground.
| "Pages/Shared/_LoginPartial.cshtml", | ||
| "Pages/Shared/_ValidationScriptsPartial.cshtml", | ||
| "Properties/launchSettings.json", | ||
| "wwwroot/favicon.ico", | ||
| "wwwroot/css/site.css", |
There was a problem hiding this comment.
We generally don't ship empty files though. Particularly not one that isn't referenced by the app. Let's remove this, users can always add one back if they want to.
|
@captainsafia do we plan on merging this in to main too? |
|
@pranavkm Yep. |
|
@dotnet/aspnet-build Can I get help merging? |
* Update templates to use scoped CSS * Move html and body styles to static CSS file
Address #31030