Skip to content

Throw when unsupported HTTPS options are set for HTTP/3 #35532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 20, 2021
Merged

Throw when unsupported HTTPS options are set for HTTP/3 #35532

merged 8 commits into from
Aug 20, 2021

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Aug 19, 2021

Fixes #34739. I'll open a backport to rc1 once approved.

@wtgodbe wtgodbe added the HTTP3 label Aug 19, 2021
@ghost ghost added the area-runtime label Aug 19, 2021
wtgodbe
wtgodbe commented Aug 19, 2021
View reviewed changes
Tratcher
Tratcher approved these changes Aug 19, 2021
View reviewed changes
JamesNK
JamesNK reviewed Aug 19, 2021
View reviewed changes
Copy link
Member

@JamesNK JamesNK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The string nameof changes probably won't compile by default. Also need to update test.

@JamesNK
Copy link
Member

JamesNK commented Aug 19, 2021

I'll open a backport to rc1 once approved.

6.0 branch is fine. These changes aren't urgent.

@wtgodbe
Copy link
Member Author

wtgodbe commented Aug 19, 2021

/backport to release/6.0

@github-actions
Copy link
Contributor

Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1148838039

@github-actions github-actions bot mentioned this pull request Aug 19, 2021
Merged
@wtgodbe wtgodbe enabled auto-merge (squash) August 20, 2021 16:36
@wtgodbe wtgodbe merged commit ebc3c51 into main Aug 20, 2021
@wtgodbe wtgodbe deleted the wtgodbe/BadOptions branch August 20, 2021 16:46
@ghost ghost added this to the 7.0-preview1 milestone Aug 20, 2021
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityamandaleeka adityamandaleeka adityamandaleeka approved these changes

@JamesNK JamesNK JamesNK approved these changes

@Tratcher Tratcher Tratcher approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions HTTP3
Projects
None yet
Milestone
7.0-preview1
Development

Successfully merging this pull request may close these issues.

Throw when unsupported HTTPS options are set for HTTP/3
5 participants
@wtgodbe @JamesNK @adityamandaleeka @Tratcher @amcasey