Skip to content

Fix AsyncEnumerableTest to actually test GetAllProjectsAsTask endpoint #35514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

campersau
Copy link
Contributor

PR Title
Call the correct endpoint for AsyncEnumerableWrappedInTask which before was the same as AsyncEnumerableReturnedWorks.

PR Description
AsyncEnumerableWrappedInTask didn't call GetAllProjectsAsTask which jugding from the method names it seems like it should.

[HttpGet]
public async Task<IAsyncEnumerable<Project>> GetAllProjectsAsTask()
{
await Task.Yield();
return GetAllProjectsCore();
}

@ghost ghost added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates community-contribution Indicates that the PR has been added by a community member labels Aug 19, 2021
@pranavkm pranavkm enabled auto-merge (squash) August 19, 2021 17:59
@pranavkm
Copy link
Contributor

Thanks!

@pranavkm pranavkm merged commit 721c539 into dotnet:main Aug 19, 2021
@ghost ghost added this to the 7.0-preview1 milestone Aug 19, 2021
@campersau campersau deleted the asyncenumerabletest branch August 19, 2021 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants