Skip to content

More LoggerMessageAttribute #35368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 17, 2021
Merged

More LoggerMessageAttribute #35368

merged 2 commits into from
Aug 17, 2021

Conversation

pranavkm
Copy link
Contributor

  • src/Middleware
  • Some MVC projects

@pranavkm
More LoggerMessageAttribute
25eb261 
* src/Middleware
* Some MVC projects
@pranavkm
Fixup
990a7d6
@pranavkm pranavkm marked this pull request as ready for review August 16, 2021 19:35
adityamandaleeka
adityamandaleeka approved these changes Aug 17, 2021
View reviewed changes
Copy link
Member

@adityamandaleeka adityamandaleeka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, provided that the change of IDs in PageLoggerExtensions is intentional and safe.

@pranavkm pranavkm merged commit 61fc66c into main Aug 17, 2021
@pranavkm pranavkm deleted the prkrishn/logger-message-2 branch August 17, 2021 23:54
@ghost ghost added this to the 6.0-rc1 milestone Aug 17, 2021
@pranavkm
Copy link
Contributor Author

For the Razor Pages logger ids, we think the change is fine. The current implementation re-uses IDs for similar log statements but it's not a pattern we could continue using with the source generator. Using distinct ids should be fine. I'll file a breaking change announcement for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityamandaleeka adityamandaleeka adityamandaleeka approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@javiercn javiercn Awaiting requested review from javiercn

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0-rc1
Development

Successfully merging this pull request may close these issues.
2 participants
@pranavkm @adityamandaleeka