Skip to content

Package r2rmap files in crossgened SFX symbol package #35288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2021
Merged

Package r2rmap files in crossgened SFX symbol package #35288

merged 1 commit into from
Aug 13, 2021

Conversation

hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Aug 12, 2021

Crossgen2 now produces perfmap files that don't need the mvid in the name. This is work necessary to provide better profiling experience in different tools.

cc: @brianrob, @trylek, @tommcdon

@hoyosjs hoyosjs requested review from dougbu and wtgodbe August 12, 2021 10:39
@hoyosjs hoyosjs requested a review from Pilchie as a code owner August 12, 2021 10:39
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Aug 12, 2021
wtgodbe
wtgodbe approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable - this just changes the contents of the SharedFx symbol package to include .r2rmap instead of .map? Did you confirm (and check the SharedFx package itself too)?

@hoyosjs
Copy link
Member Author

hoyosjs commented Aug 13, 2021 •
edited
Loading

Yup. Checked with an official build that all things are as expected and that the builds didn't break. After and before:

image

@hoyosjs hoyosjs merged commit ad3ab1e into dotnet:main Aug 13, 2021
@ghost ghost added this to the 6.0-rc1 milestone Aug 13, 2021
@hoyosjs hoyosjs deleted the juhoyosa/r2rmap-support branch August 13, 2021 01:01
@trylek trylek mentioned this pull request Aug 31, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

@dougbu dougbu Awaiting requested review from dougbu

@Pilchie Pilchie Awaiting requested review from Pilchie

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
6.0-rc1
Development

Successfully merging this pull request may close these issues.
2 participants
@hoyosjs @wtgodbe