Skip to content

Support generic array parameters in components #34734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2021
Merged

Support generic array parameters in components #34734

merged 1 commit into from
Aug 31, 2021

Conversation

campersau
Copy link
Contributor

PR Title
Using generic arrays as component parameters resulted in compilation failures which are now fixed.

PR Description
Before it was only possible to have generic parameters like IList<T> / Func<T> but not T[] / IList<T[]> / Func<T[]> because a different check for arrays is required.

Fixes #34711

@campersau campersau requested a review from Pilchie as a code owner July 26, 2021 19:41
@ghost ghost added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates community-contribution Indicates that the PR has been added by a community member labels Jul 26, 2021
@campersau campersau mentioned this pull request Jul 26, 2021
Closed
@Pilchie
Copy link
Member

Pilchie commented Jul 26, 2021

Tagging @captainsafia @pranavkm @NTaylorMullen

@campersau campersau force-pushed the componenttypearray branch from a971708 to 10aadcc Compare July 26, 2021 20:19
@SteveSandersonMS SteveSandersonMS mentioned this pull request Aug 3, 2021
Closed
@SteveSandersonMS
Copy link
Member

When merging, check if this fixes #29105

@pranavkm
Copy link
Contributor

pranavkm commented Aug 3, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@SteveSandersonMS SteveSandersonMS mentioned this pull request Aug 12, 2021
Closed
@pranavkm pranavkm enabled auto-merge (squash) August 26, 2021 16:53
@pranavkm pranavkm merged commit cfc5aff into dotnet:main Aug 31, 2021
@ghost ghost added this to the 7.0-preview1 milestone Aug 31, 2021
@pranavkm
Copy link
Contributor

/backport to release/6.0

@github-actions
Copy link
Contributor

Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1187192990

@github-actions github-actions bot mentioned this pull request Aug 31, 2021
Merged
@campersau campersau deleted the componenttypearray branch August 31, 2021 18:03
@guardrex guardrex mentioned this pull request Dec 30, 2021
Closed
@guardrex guardrex mentioned this pull request Jan 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavkm pranavkm pranavkm approved these changes

@Pilchie Pilchie Awaiting requested review from Pilchie

Assignees

@pranavkm pranavkm

@SteveSandersonMS SteveSandersonMS

Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
7.0-preview1
Development

Successfully merging this pull request may close these issues.

Blazor component with generics incorrectly invokes Func<T[]> that is a parameter
5 participants
@campersau @Pilchie @SteveSandersonMS @pranavkm @javiercn