Skip to content

[main] Update dependencies from dotnet/arcade #34097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 8, 2021
Merged

[main] Update dependencies from dotnet/arcade #34097

merged 2 commits into from
Jul 8, 2021

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jul 5, 2021 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 89b8d7af-c2e7-42f8-3b29-08d8b8050dda
  • Build: 20210707.3
  • Date Produced: 7/7/2021 9:31 PM
  • Commit: 286d98094b830b8dad769542b2669cb1b75f7097
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
66d7cfd 
…701.2

Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21329.1 -> To Version 6.0.0-beta.21351.2
@dotnet-maestro dotnet-maestro bot requested review from dougbu and a team as code owners July 5, 2021 12:07
@ghost ghost added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼 labels Jul 5, 2021
ghost
ghost approved these changes Jul 5, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

@ghost ghost added the tell-mode Indicates a PR which is being merged during tell-mode label Jul 5, 2021
@TanayParikh
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@TanayParikh
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@dougbu
Copy link
Contributor

dougbu commented Jul 7, 2021

Some change in the new Arcade bits is breaking our correlation payload. That, in turn, breaks most of the shared Fx and targeting pack tests.

From the failed work item's console log:

Displaying directory contents for /datadisks/disk1/work/AF99096D/p/dotnet-cli/shared/Microsoft.AspNetCore.App:
6.0.0-preview.7.21355.4

Displaying directory contents for /datadisks/disk1/work/AF99096D/p/dotnet-cli/packs/Microsoft.AspNetCore.App.Ref:
6.0.0-preview.7.21355.4

In an earlier (successful) build of main, the console log instead shows:

Displaying directory contents for /datadisks/disk1/work/AB8C09C2/p/dotnet-cli/shared/Microsoft.AspNetCore.App:
6.0.0-ci
6.0.0-preview.7.21355.4


Displaying directory contents for /datadisks/disk1/work/AB8C09C2/p/dotnet-cli/packs/Microsoft.AspNetCore.App.Ref:
6.0.0-ci
6.0.0-preview.7.21355.4

@TanayParikh TanayParikh mentioned this pull request Jul 7, 2021
Closed
@HaoK
Copy link
Member

HaoK commented Jul 7, 2021

Aren't you glad I kept those 2 lines displaying the contents of the framework directories now @dougbu ? :)

@dougbu
Copy link
Contributor

dougbu commented Jul 7, 2021

Aren't you glad I kept those 2 lines displaying the contents of the framework directories now @dougbu ? :)

Yup❕

@TanayParikh TanayParikh added the blocked The work on this issue is blocked due to some dependency label Jul 7, 2021
@TanayParikh
Copy link
Contributor

Blocked on propagation of additional arcade changes.

@TanayParikh TanayParikh mentioned this pull request Jul 8, 2021
Closed
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
3cde307 
…707.3

Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21329.1 -> To Version 6.0.0-beta.21357.3
@dougbu
Copy link
Contributor

dougbu commented Jul 8, 2021

Blocked on propagation of additional arcade changes.

New Arcade build is now in the '.NET Eng - Latest' channel w/ @missymessa's fixes (thanks ❕) and I triggered the subscription. Hopefully this CI build will succeed 😃

@dotnet-maestro dotnet-maestro bot merged commit db8af42 into main Jul 8, 2021
@dotnet-maestro dotnet-maestro bot deleted the darc-main-e47dc6f3-96fc-43e9-beb6-c86fecb92329 branch July 8, 2021 02:23
@ghost ghost added this to the 6.0-preview7 milestone Jul 8, 2021
@dougbu dougbu removed the blocked The work on this issue is blocked due to some dependency label Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TanayParikh TanayParikh TanayParikh approved these changes

@dougbu dougbu Awaiting requested review from dougbu

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode Type: Dependency Update 🔼
Projects
None yet
Milestone
6.0-preview7
Development

Successfully merging this pull request may close these issues.
3 participants
@TanayParikh @dougbu @HaoK