Support Request, Response and User for minimal actions #33883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support to minimal actions for parameters of type HttpRequest, HttpResponse, and ClaimsPrincipal to be bound to the values of the Request, Response and User properties of the HttpContext respectively. Also cleans up some typos in the RequestDelegateFactory tests. Addresses dotnet#33870.
ghost
added
area-runtime
community-contribution
martincostello
commented
Jun 27, 2021
|
@martincostello one thing we missed is the api explorer support . Right now these will show up as coming from the body isn't correct. |
|
Good spot. Do you want me to push up a PR to amend that? |
|
Hi @martincostello. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
Yep! |
martincostello
added a commit
to martincostello/aspnetcore
that referenced
this pull request
Jul 7, 2021
Fix minimal actions parameters for HttpRequest, HttpResponse and ClaimsPrincipal being marked as body parameters by API Explorer. Relates to dotnet#33870 and dotnet#33883.
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Title
Support Request, Response and User for minimal actions
PR Description
Adds support to minimal actions for parameters of type
HttpRequest,HttpResponse, andClaimsPrincipalto be bound to the values of theRequest,ResponseandUserproperties of theHttpContextrespectively.Also cleans up some typos and IDE suggestions in the
RequestDelegateFactorytests.Fixes #33870