[release/6.0-preview6] Don't add service parameters to an endpoint ApiDescriptions #33728
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #33727 to release/6.0-preview6
Before:
After:
/cc @halter73
Customer Impact
Service parameters (those that are resolved from the RequestServices IServiceProvider) for minimal actions show up in the swagger.json and UI as a schema even though there should be none as the parameter in no way comes from the request.
Testing
I tested this manually with Swashbuckle.AspNetCore 5.6.3 from NuGet and verified the service schema no longer shows up in swagger.json or the UI. I also updated the unit tests to verify nothing is added to the API metadata for parameters that come from the
Risk
Low. This can only affect applications that call the new
AddEndpointsApiExplorer()
API added in preview6.