Skip to content

Add option to the JSON.NET output formatter #32747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2021

Conversation

davidfowl
Copy link
Member

  • Add an option to increase the buffer threshold for writing to the output. We have several long standing performance issues with the JSON.NET output formatter and this addresses one of them by making the buffer threshold before going to disk configurable.

Fixes #17843

PS: There are other performance issues with the FileBuffering*Streams but this doesn't try to address those. We have another issue for that

- Add an option to increase the buffer threshold for writing to the output. We have several long standing performance issues with the JSON.NET output formatter and this addresses one of them by making the buffer threshold before going to disk configurable.
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label May 16, 2021
@davidfowl davidfowl added the api-ready-for-review API is ready for formal API review - https://github.com/dotnet/apireviews label May 16, 2021
@ghost
Copy link

ghost commented May 16, 2021

Thank you for submitting this for API review. This will be reviewed by @dotnet/aspnet-api-review at the next meeting of the ASP.NET Core API Review group. Please ensure you take a look at the API review process documentation and ensure that:

  • The PR contains changes to the reference-assembly that describe the API change. Or, you have included a snippet of reference-assembly-style code that illustrates the API change.
  • The PR describes the impact to users, both positive (useful new APIs) and negative (breaking changes).
  • Someone is assigned to "champion" this change in the meeting, and they understand the impact and design of the change.

@davidfowl davidfowl requested a review from jkotalik as a code owner May 16, 2021 18:39
@pranavkm pranavkm added api-approved API was approved in API review, it can be implemented and removed api-ready-for-review API is ready for formal API review - https://github.com/dotnet/apireviews labels May 17, 2021
@davidfowl
Copy link
Member Author

/azp run aspnetcore-ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@davidfowl
Copy link
Member Author

davidfowl commented May 18, 2021

@pranavkm @captainsafia can you take a look at this failure?

@davidfowl
Copy link
Member Author

/azp run aspnetcore-ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@captainsafia
Copy link
Member

The build failures are related to some expired certificates. The fix was merged in #32812 just now.

@captainsafia
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@davidfowl
Copy link
Member Author

I give up

@davidfowl
Copy link
Member Author

/azp run aspnetcore-ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@davidfowl davidfowl merged commit 0b8a066 into main May 19, 2021
@davidfowl davidfowl deleted the davidfowl/fix-json-net-buffersize branch May 19, 2021 15:22
@ghost ghost added this to the 6.0-preview5 milestone May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-approved API was approved in API review, it can be implemented area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

High disk IO volume after upgrading to 3.0
4 participants