-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Add option to the JSON.NET output formatter #32747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add an option to increase the buffer threshold for writing to the output. We have several long standing performance issues with the JSON.NET output formatter and this addresses one of them by making the buffer threshold before going to disk configurable.
Thank you for submitting this for API review. This will be reviewed by @dotnet/aspnet-api-review at the next meeting of the ASP.NET Core API Review group. Please ensure you take a look at the API review process documentation and ensure that:
|
src/Mvc/Mvc.NewtonsoftJson/test/NewtonsoftJsonOutputFormatterTest.cs
Outdated
Show resolved
Hide resolved
/azp run aspnetcore-ci |
Azure Pipelines successfully started running 1 pipeline(s). |
@pranavkm @captainsafia can you take a look at this failure? |
/azp run aspnetcore-ci |
Azure Pipelines successfully started running 1 pipeline(s). |
The build failures are related to some expired certificates. The fix was merged in #32812 just now. |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
I give up |
/azp run aspnetcore-ci |
Azure Pipelines successfully started running 1 pipeline(s). |
Fixes #17843
PS: There are other performance issues with the FileBuffering*Streams but this doesn't try to address those. We have another issue for that