Cleanup Helix infrastructure slightly #32554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove `$(Configuration)` and `$(PlatformName)` from output path - other layouts aren't that specific - properties weren't available anyhow in some cases nits: - provide the .version file expected in .dotnet/shared/… - rename `AspNetCoreAppRuntimeHelix/` -> `SharedFx.Layout/`; same for the correlation payload archive - rename `AspNetCoreAppRuntimeHelixRaw/` -> `SharedFx.Unzip/`
nit: use `[switch]` instead of `[bool]`
ghost
added
the
area-infrastructure
|
/fyi issues found while playing in #32508 (my playground for testing @davidwrighton's #31778) |
HaoK
reviewed
May 10, 2021
| @@ -120,11 +120,6 @@ | |||
| </PropertyGroup> | |||
| </Target> | |||
|
|
|||
| <Target Name="_PublishHelixArchive" DependsOnTargets="Publish" > | |||
There was a problem hiding this comment.
I vaguely recall IIS functional tests using this, or at least this is why it was added, did they move to something else?
There was a problem hiding this comment.
There are no mentions of this target in the repo after removing this. And, nothing remained that set $(HelixUseArchive) to true before I started. @jkotalik was the "archiving for IIS tests on Helix" requirement removed at some point❔
|
Green. Just waiting for approval… |
HaoK
approved these changes
May 11, 2021
dougbu
added a commit
that referenced
this pull request
May 27, 2021
- cherry-pick of #32894 * Clean out Ubuntu 16.04 testing - use Ubuntu 18.04 agents for testing in Docker containers on Helix - also move to supported version of Fedora * Support added `msbuild` arguments in RunHelix.ps1 - bring in part of 0551cef (#32554) - no reason to maintain major differences from main version of script - slight difference is we still test on Windows.10.Amd64.Open by default here nits: - clean up a few old mentions of Centos and Fedora testing - fix `%(Platform)` metadata for OSX `@(HelixAvailableTargetQueue)` items - pick up a small bit of the master -> main renaming improvements - use `[switch]` instead of `[bool]` in RunHelix.ps1 parameters
dougbu
added a commit
that referenced
this pull request
Jun 1, 2021
* [release/5.0] Clean out Ubuntu 16.04 testing - cherry-pick of #32894 * Clean out Ubuntu 16.04 testing - use Ubuntu 18.04 agents for testing in Docker containers on Helix - also move to supported version of Fedora * Support added `msbuild` arguments in RunHelix.ps1 - bring in part of 0551cef (#32554) - no reason to maintain major differences from main version of script - slight difference is we still test on Windows.10.Amd64.Open by default here nits: - clean up a few old mentions of Centos and Fedora testing - fix `%(Platform)` metadata for OSX `@(HelixAvailableTargetQueue)` items - pick up a small bit of the master -> main renaming improvements - use `[switch]` instead of `[bool]` in RunHelix.ps1 parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove unused
$(HelixUseArchive)propertymove helix.proj output into artifacts/bin/helix/
$(Configuration)and$(PlatformName)from output pathnits:
AspNetCoreAppRuntimeHelix/->SharedFx.Layout/; same for the correlation payload archiveAspNetCoreAppRuntimeHelixRaw/->SharedFx.Unzip/support added
msbuildarguments in RunHelix.ps1nit: use
[switch]instead of[bool]